Opened 2 years ago
Closed 2 years ago
#22917 closed defect (fixed)
update zlib to 1.2.11
Reported by:  dimpase  Owned by:  

Priority:  major  Milestone:  sage8.0 
Component:  packages: standard  Keywords:  
Cc:  fbissey, embray  Merged in:  
Authors:  Dima Pasechnik  Reviewers:  François Bissey, JeanPierre Flori 
Report Upstream:  N/A  Work issues:  
Branch:  b0bd679 (Commits)  Commit:  b0bd679bac601a58a56ea781ae5f3ec61180d3a0 
Dependencies:  #22582  Stopgaps: 
Description
time to update and to fix weirdness in handling CC=cc
, cf
this comment on #12426.
tarball here
Change History (12)
comment:1 Changed 2 years ago by
 Branch set to u/dimpase/zlib112
 Commit set to f3295dcfd12e2bc972202166a75de6621f9cc1b2
comment:2 Changed 2 years ago by
 Cc fbissey embray added
 Status changed from new to needs_review
OK, this is the update. Note that it needed an update of the Cygwin patch, thus a review on Cygwin is most appreciated.
comment:3 Changed 2 years ago by
I am OK with this if the cygwin patch is appropriate.
comment:4 Changed 2 years ago by
The cygwin patch update looks ok form a functional point of view but looses a tiny piece of info stuffed into the patch.
comment:5 Changed 2 years ago by
 Status changed from needs_review to needs_work
In fact the patch should not be necessary anymore:
Please remove it.
It should still be nice to test it on Cygwin, @eric: can you do it?
comment:6 Changed 2 years ago by
 Commit changed from f3295dcfd12e2bc972202166a75de6621f9cc1b2 to c17bc1a2be26a9641fde6837f148d9c6a9da7c80
comment:7 Changed 2 years ago by
 Commit changed from c17bc1a2be26a9641fde6837f148d9c6a9da7c80 to b0bd679bac601a58a56ea781ae5f3ec61180d3a0
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
b0bd679  obsoleted by github.com/madler/zlib/issues/45

comment:9 Changed 2 years ago by
 Reviewers set to François Bissey, JeanPierre Flori
 Status changed from needs_review to positive_review
Good, let's merge it then.
comment:10 Changed 2 years ago by
I haven't tested it yet, but I don't imagine it will be a problem. It would be nicer though if we could use the system zlib. I'm working up a proposal for how to enable that more generally...
comment:11 Changed 2 years ago by
Sure but as you say, it's a wider and different issue.
comment:12 Changed 2 years ago by
 Branch changed from u/dimpase/zlib112 to b0bd679bac601a58a56ea781ae5f3ec61180d3a0
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
Merge tag '8.0.beta2' into t/22582/install_python_packages_into_2_and_3
trac 22582: fix merge conflicts
trac 22582: rename build/bin/sagepython to sagepython23
trac 22582: use sagepython23 to build the Sage library
trac 22582: build and test packages using sagepython23 instead of python
trac 22582: no need to make python2 a dependency for python3
trac 22582: a little documentation
Merge branch 'public/22582' of trac.sagemath.org:sage into t/22582/public/22582
Merge branch 8.0.beta3 into t/22582/public/22582
Merge branch 'public/22582' of trac.sagemath.org:sage into zlibupdate