Opened 3 years ago

Closed 3 years ago

#22916 closed enhancement (fixed)

py3 use six.string_types in a few places

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords: unicode
Cc: tscrim, jdemeyer, aapitzsch, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e009a0d (Commits) Commit: e009a0d7cff1951eae61680c62a467133f1503ff
Dependencies: Stopgaps:

Description

(very tiny) part of #16079

Change History (11)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/22916
  • Cc tscrim jdemeyer aapitzsch jmantysalo added
  • Commit set to 66c21bae27cf5f92bc8ab888db9e75013106d1bf
  • Status changed from new to needs_review

should be a very easy review


New commits:

66c21bapy3: using six.string_types in a few places

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 3 years ago by chapoton

  • Keywords unicode added

comment:4 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:5 Changed 3 years ago by git

  • Commit changed from 66c21bae27cf5f92bc8ab888db9e75013106d1bf to f2993ddd7f1db6940ba3db23d1edbfdd5c2bb294

Branch pushed to git repo; I updated commit sha1. New commits:

f2993ddMerge branch 'u/chapoton/22916' in 8.0.b5

comment:6 Changed 3 years ago by chapoton

  • Status changed from needs_work to positive_review

trivial rebase done, setting back to positive

comment:7 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

See patchbot...

comment:8 Changed 3 years ago by git

  • Commit changed from f2993ddd7f1db6940ba3db23d1edbfdd5c2bb294 to e009a0d7cff1951eae61680c62a467133f1503ff

Branch pushed to git repo; I updated commit sha1. New commits:

977ec0cMerge branch 'u/chapoton/22916' in 8.0.b6
e009a0dtrac 22916 fix detail

comment:9 Changed 3 years ago by chapoton

  • Status changed from needs_work to needs_review

corrected now


New commits:

977ec0cMerge branch 'u/chapoton/22916' in 8.0.b6
e009a0dtrac 22916 fix detail

comment:10 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/22916 to e009a0d7cff1951eae61680c62a467133f1503ff
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.