Opened 5 years ago

Closed 5 years ago

#22916 closed enhancement (fixed)

py3 use six.string_types in a few places

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords: unicode
Cc: Travis Scrimshaw, Jeroen Demeyer, aapitzsch, Jori Mäntysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e009a0d (Commits, GitHub, GitLab) Commit: e009a0d7cff1951eae61680c62a467133f1503ff
Dependencies: Stopgaps:

Status badges

Description

(very tiny) part of #16079

Change History (11)

comment:1 Changed 5 years ago by Frédéric Chapoton

Branch: u/chapoton/22916
Cc: Travis Scrimshaw Jeroen Demeyer aapitzsch Jori Mäntysalo added
Commit: 66c21bae27cf5f92bc8ab888db9e75013106d1bf
Status: newneeds_review

should be a very easy review


New commits:

66c21bapy3: using six.string_types in a few places

comment:2 Changed 5 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:3 Changed 5 years ago by Frédéric Chapoton

Keywords: unicode added

comment:4 Changed 5 years ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict

comment:5 Changed 5 years ago by git

Commit: 66c21bae27cf5f92bc8ab888db9e75013106d1bff2993ddd7f1db6940ba3db23d1edbfdd5c2bb294

Branch pushed to git repo; I updated commit sha1. New commits:

f2993ddMerge branch 'u/chapoton/22916' in 8.0.b5

comment:6 Changed 5 years ago by Frédéric Chapoton

Status: needs_workpositive_review

trivial rebase done, setting back to positive

comment:7 Changed 5 years ago by Volker Braun

Status: positive_reviewneeds_work

See patchbot...

comment:8 Changed 5 years ago by git

Commit: f2993ddd7f1db6940ba3db23d1edbfdd5c2bb294e009a0d7cff1951eae61680c62a467133f1503ff

Branch pushed to git repo; I updated commit sha1. New commits:

977ec0cMerge branch 'u/chapoton/22916' in 8.0.b6
e009a0dtrac 22916 fix detail

comment:9 Changed 5 years ago by Frédéric Chapoton

Status: needs_workneeds_review

corrected now


New commits:

977ec0cMerge branch 'u/chapoton/22916' in 8.0.b6
e009a0dtrac 22916 fix detail

comment:10 Changed 5 years ago by Travis Scrimshaw

Status: needs_reviewpositive_review

comment:11 Changed 5 years ago by Volker Braun

Branch: u/chapoton/22916e009a0d7cff1951eae61680c62a467133f1503ff
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.