Opened 5 years ago
Closed 5 years ago
#22908 closed enhancement (fixed)
generator of random block graph
Reported by:  dcoudert  Owned by:  

Priority:  major  Milestone:  sage8.0 
Component:  graph theory  Keywords:  graph, generator, block graph, incidence structure 
Cc:  Merged in:  
Authors:  David Coudert  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  acba60a (Commits, GitHub, GitLab)  Commit:  acba60a87a465139a2f9cab59a9976b9366a01ac 
Dependencies:  Stopgaps: 
Description
Following discussion on https://ask.sagemath.org/question/37433/randomblockgraph/, this ticket implements a generator of random block graphs, as well as recognition method.
The definition of block graph can be found at https://en.wikipedia.org/wiki/Block_graph
Change History (17)
comment:1 Changed 5 years ago by
 Branch set to u/dcoudert/22908
 Commit set to 1f6453736b812d5976041e48e25ac1c618322346
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Commit changed from 1f6453736b812d5976041e48e25ac1c618322346 to 753c6906f1156956a94f78a26a258ef3f7473fc9
Branch pushed to git repo; I updated commit sha1. New commits:
753c690  trac #22908: add example using graph_classes

comment:3 followup: ↓ 5 Changed 5 years ago by
some minor comments:
 you may also want to point to "blocks_and_cuts_tree" in the SEE ALSO
 the first line of a function "Return something of interest." should end with a dot
 and the verb in the first line should take no s ("Test if something is something.")
comment:4 Changed 5 years ago by
 Commit changed from 753c6906f1156956a94f78a26a258ef3f7473fc9 to 452b64d6e5fc96e6ec615ac445f0985d7faabf85
Branch pushed to git repo; I updated commit sha1. New commits:
452b64d  trac #22908: implement reviewers comments

comment:5 in reply to: ↑ 3 Changed 5 years ago by
Replying to chapoton:
some minor comments:
 you may also want to point to "blocks_and_cuts_tree" in the SEE ALSO
done
 the first line of a function "Return something of interest." should end with a dot
I'm always confused with that with or without dot. done
 and the verb in the first line should take no s ("Test if something is something.")
done
Thanks.
comment:6 Changed 5 years ago by
 Commit changed from 452b64d6e5fc96e6ec615ac445f0985d7faabf85 to b19465feb1a1488934da6ee6da880534bba487c1
comment:7 Changed 5 years ago by
I have corrected the link to incidence structures in the see also section and added an example with recognition methods.
comment:8 Changed 5 years ago by
 Commit changed from b19465feb1a1488934da6ee6da880534bba487c1 to 52381bcedd9b3105062d2c70708f20ccd2d09176
comment:9 Changed 5 years ago by
One sentence sounds wrong:
Every biconnected components of a block graph are cliques
comment:10 Changed 5 years ago by
Should be correct, but I can replace it by "Each biconnected component of a block graph is a clique" ou "All biconnected components of a block graph are cliques".
comment:11 Changed 5 years ago by
comment:12 Changed 5 years ago by
 Commit changed from 52381bcedd9b3105062d2c70708f20ccd2d09176 to 0eca6051517836832bfd051bb5e8f659a71e9b7f
comment:13 Changed 5 years ago by
oups... push error. I will try to fix that.
comment:14 Changed 5 years ago by
 Branch changed from u/dcoudert/22908 to public/22908
 Commit changed from 0eca6051517836832bfd051bb5e8f659a71e9b7f to acba60a87a465139a2f9cab59a9976b9366a01ac
New commits:
acba60a  trac #22908: corrections

comment:15 Changed 5 years ago by
I have apparently been able to fix my error. I'm always having hard time with git... The branch is now in public. I also tried to fix the grammar issues.
New commits:
acba60a  trac #22908: corrections

comment:16 Changed 5 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, let it be
comment:17 Changed 5 years ago by
 Branch changed from public/22908 to acba60a87a465139a2f9cab59a9976b9366a01ac
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
trac #22908: generator of random block graphs
trac #22908: test if a graph is a block graphs
trac #22908: add methods to graph_classes
trac #22908: fix doc in isgci