Opened 4 years ago

Closed 4 years ago

#22892 closed enhancement (fixed)

py3 : about range in homology folder

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: John Palmieri, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f6a1c53 (Commits, GitHub, GitLab) Commit: f6a1c53106d1412d19c0fe3655232874429c56a7
Dependencies: Stopgaps:

Status badges

Description

part of #16081

Change History (7)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/22892
  • Commit set to fd002ed600b70b9209727f1927592931b97f315c
  • Status changed from new to needs_review

New commits:

fd002edsome care for range in homology folder

comment:2 Changed 4 years ago by jhpalmieri

  • Branch changed from u/chapoton/22892 to u/jhpalmieri/22892

comment:3 Changed 4 years ago by jhpalmieri

  • Commit changed from fd002ed600b70b9209727f1927592931b97f315c to f6a1c53106d1412d19c0fe3655232874429c56a7

Here are some proposed changes. I tried to modify things so that the code would accept Python 3 ranges in more places, rather than just converting to lists or tuples.


New commits:

f6a1c53trac 22892: range for simplicial complexes and homology

comment:4 Changed 4 years ago by tscrim

  • Cc tscrim added

comment:5 Changed 4 years ago by chapoton

ok, looks good enough. Travis, do you agree ?

comment:6 Changed 4 years ago by tscrim

  • Reviewers set to John Palmieri, Travis Scrimshaw
  • Status changed from needs_review to positive_review

Indeed I do.

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/jhpalmieri/22892 to f6a1c53106d1412d19c0fe3655232874429c56a7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.