Opened 2 years ago

Closed 2 years ago

#22844 closed enhancement (fixed)

Symbolic limit

Reported by: rws Owned by:
Priority: major Milestone: sage-8.0
Component: symbolics Keywords:
Cc: charpent Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ce95d01 (Commits) Commit: ce95d015a7073fb32743dfbeb184582ca3da1ce2
Dependencies: Stopgaps:

Description

Equivalently to #21645 a symbolic limit function is needed, in this case #20179 supposes that expressions can be searched for unexpanded limit functions which is not possible if it is anonymous.

Change History (15)

comment:1 Changed 2 years ago by rws

  • Branch set to u/rws/symbolic_limit

comment:2 Changed 2 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 2f5a28f235a1b61cdb5c394bf5743d6c242afea6
  • Status changed from new to needs_review

comment:3 Changed 2 years ago by git

  • Commit changed from 2f5a28f235a1b61cdb5c394bf5743d6c242afea6 to bd403fd911b32e4116125f12c51d1e0359e3e835

Branch pushed to git repo; I updated commit sha1. New commits:

bd403fd22844:internal symbolic limit function

comment:4 Changed 2 years ago by charpent

  • Cc charpent added

comment:5 Changed 2 years ago by rws

  • Status changed from needs_review to needs_work

Doctest failures in src/sage/calculus/calculus.py.

comment:6 Changed 2 years ago by rws

The latex conversion would be easily fixed. However, the fails show that there is the problem that the limit function can have either 3 or 4 arguments, the latter with an additional direction. I don't think Sage can handle this at the moment without tuples as arguments like in hypergeometric, and this would change the code substantially.

EDIT: it may be possible to use two functions; checks elsewhere would then have to be done with both. The Maxima interface would have to know about it.

Last edited 2 years ago by rws (previous) (diff)

comment:7 Changed 2 years ago by rws

Maybe it is excusable in this case to write a customized __call__ member, as long as it's an internally only used function.

comment:8 Changed 2 years ago by git

  • Commit changed from bd403fd911b32e4116125f12c51d1e0359e3e835 to bd0a226c693a793ada956d045ae898e88b271972

Branch pushed to git repo; I updated commit sha1. New commits:

38e6441Merge branch 'develop' into t/22844/symbolic_limit
bd0a22622844: latex conversion, direction arg, interface cleanup

comment:9 Changed 2 years ago by rws

  • Status changed from needs_work to needs_review

Much easier: nargs=0 does the trick. Please review.

comment:10 Changed 2 years ago by tscrim

Needs a rebase over the latest develop.

comment:11 Changed 2 years ago by git

  • Commit changed from bd0a226c693a793ada956d045ae898e88b271972 to 14f26478d05e4c5cfda934a2757a56b5a9c3afed

Branch pushed to git repo; I updated commit sha1. New commits:

14f2647Merge branch 'develop' into t/22844/symbolic_limit

comment:12 Changed 2 years ago by git

  • Commit changed from 14f26478d05e4c5cfda934a2757a56b5a9c3afed to ce95d015a7073fb32743dfbeb184582ca3da1ce2

Branch pushed to git repo; I updated commit sha1. New commits:

ce95d01Merge branch 'develop' into t/22844/symbolic_limit

comment:13 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:14 Changed 2 years ago by rws

Thanks.

comment:15 Changed 2 years ago by vbraun

  • Branch changed from u/rws/symbolic_limit to ce95d015a7073fb32743dfbeb184582ca3da1ce2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.