Opened 13 years ago

Closed 13 years ago

#2282 closed defect (fixed)

[with link to spkg, positive review] readline currently not building dynamic library on Mac

Reported by: craigcitro Owned by: craigcitro
Priority: major Milestone: sage-2.10.3
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Currently, readline fails to build a dynamic library on Mac, and the sage installer doesn't notice this at all. Once this happens, other things (notably Pari) can't find readline, and know not to build against the system-wide fake readline (Mac ships a pseudo-readline for licensing reasons). Pari then doesn't have readline support, and is annoying to use. Luckily, there was a fix on the FAQ, which I've added to our spkg-install for readline when we're on a Mac.

So there are really two things I've changed:

  • Add the fix for building readline (this involves changing dynamic to dynamiclib in the generated Makefile)
  • Change -o to -a in spkg-install: this is why we weren't noticing that readline failed to build.

Of course, I don't know why it was -o instead of -a in the first place: if there was a good reason for that, someone should let me know and I'll change it back in the non-Mac case.

Change History (4)

comment:1 Changed 13 years ago by craigcitro

  • Status changed from new to assigned

Forgot to post a link to the spkg:

. http://sage.math.washington.edu/home/citro/patches/readline-5.2.p1.spkg

Also, I failed with entering a link to the Pari FAQ above, it should be to

. http://www.ufr-mi.u-bordeaux.fr/~belabas/pari/doc/faq.html#mac10readline

comment:2 Changed 13 years ago by was

  • Summary changed from [with link to spkg, needs review] readline currently not building dynamic library on Mac to [with link to spkg, positive review] readline currently not building dynamic library on Mac

Awesome! I'm so glad you tracked this down since it was driving me nuts.

I've tested this spkg and it works perfectly. The description of the fix sounds reasonable to me, I guess. So positive review. I hope mabshoff will look more closely at spkg-install and see if it makes sense to him.

Thanks!!

comment:3 Changed 13 years ago by cwitty

The spkg works for me (install the spkg, force-install pari, check to make sure readline works for both gp and sage) on both bsd.math.washington.edu (OSX, where gp+readline was previously broken) and on my 32-bit x86 Linux box.

comment:4 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 2.10.3.alpha0

Note: See TracTickets for help on using tickets.