Opened 4 years ago
Closed 4 years ago
#22806 closed enhancement (fixed)
Stop using cdefs.pxi
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.0 |
Component: | cython | Keywords: | |
Cc: | chapoton | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | b85140a (Commits, GitHub, GitLab) | Commit: | b85140a17d884f04d98d4b4cf4fc94a4084b6030 |
Dependencies: | Stopgaps: |
Description (last modified by )
We should replace the usage of cdefs.pxi
by proper cimports because it's cleaner and because .pxi
files in general are semi-deprecated.
While I was editing those files anyway, I also added absolute_import
to many of them.
Change History (5)
comment:1 Changed 4 years ago by
- Branch set to u/jdemeyer/stop_using_cdefs_pxi
comment:2 Changed 4 years ago by
- Commit set to b85140a17d884f04d98d4b4cf4fc94a4084b6030
- Description modified (diff)
comment:3 Changed 4 years ago by
- Cc chapoton added
- Status changed from new to needs_review
@chapoton just to mention that I'm adding lots of absolute_imports here.
comment:4 Changed 4 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:5 Changed 4 years ago by
- Branch changed from u/jdemeyer/stop_using_cdefs_pxi to b85140a17d884f04d98d4b4cf4fc94a4084b6030
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Stop using cdefs.pxi