Opened 5 years ago

Closed 5 years ago

#22803 closed enhancement (fixed)

MacMahon's Omega: cancel some common factors in intermediate result

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-8.0
Component: linear algebra Keywords:
Cc: cheuberg Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: b02b7f1 (Commits, GitHub, GitLab) Commit: b02b7f1399e07b467fbfdea21a7dcff496a44935
Dependencies: Stopgaps:

Status badges

Description (last modified by cheuberg)

If a factor of the denominator divides the numerator, then cancel it out.

This concerns MacMahon's Omega operator (#22066).

Change History (5)

comment:1 Changed 5 years ago by dkrenn

  • Branch set to u/dkrenn/omega-simplify

comment:2 Changed 5 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Cc cheuberg added
  • Commit set to b02b7f1399e07b467fbfdea21a7dcff496a44935
  • Status changed from new to needs_review

New commits:

b4082d2function _simplify_ for cancelling factors in intermediate result (quotient)
b02b7f1use and test new feature in _Omega_-function

comment:3 follow-up: Changed 5 years ago by cheuberg

  • Description modified (diff)
  • Reviewers set to Clemens Heuberger

LGTM. Please set to positive review once a patchbot is happy.

comment:4 in reply to: ↑ 3 Changed 5 years ago by dkrenn

  • Status changed from needs_review to positive_review

Replying to cheuberg:

LGTM. Please set to positive review once a patchbot is happy.

Done. (Tests passed except one timeout.)

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/dkrenn/omega-simplify to b02b7f1399e07b467fbfdea21a7dcff496a44935
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.