Opened 6 years ago

Closed 6 years ago

#22803 closed enhancement (fixed)

MacMahon's Omega: cancel some common factors in intermediate result

Reported by: Daniel Krenn Owned by:
Priority: major Milestone: sage-8.0
Component: linear algebra Keywords:
Cc: Clemens Heuberger Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: b02b7f1 (Commits, GitHub, GitLab) Commit: b02b7f1399e07b467fbfdea21a7dcff496a44935
Dependencies: Stopgaps:

Status badges

Description (last modified by Clemens Heuberger)

If a factor of the denominator divides the numerator, then cancel it out.

This concerns MacMahon's Omega operator (#22066).

Change History (5)

comment:1 Changed 6 years ago by Daniel Krenn

Branch: u/dkrenn/omega-simplify

comment:2 Changed 6 years ago by Daniel Krenn

Authors: Daniel Krenn
Cc: Clemens Heuberger added
Commit: b02b7f1399e07b467fbfdea21a7dcff496a44935
Status: newneeds_review

New commits:

b4082d2function _simplify_ for cancelling factors in intermediate result (quotient)
b02b7f1use and test new feature in _Omega_-function

comment:3 Changed 6 years ago by Clemens Heuberger

Description: modified (diff)
Reviewers: Clemens Heuberger

LGTM. Please set to positive review once a patchbot is happy.

comment:4 in reply to:  3 Changed 6 years ago by Daniel Krenn

Status: needs_reviewpositive_review

Replying to cheuberg:

LGTM. Please set to positive review once a patchbot is happy.

Done. (Tests passed except one timeout.)

comment:5 Changed 6 years ago by Volker Braun

Branch: u/dkrenn/omega-simplifyb02b7f1399e07b467fbfdea21a7dcff496a44935
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.