Opened 5 years ago

Closed 5 years ago

#22795 closed defect (fixed)

Fixing a typo in error message within finite subgroups of modular abelian varieties

Reported by: klui Owned by:
Priority: trivial Milestone: sage-8.0
Component: modular forms Keywords: intersection modular abelian variety
Cc: Merged in:
Authors: Kevin Lui Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 8d9f6ab (Commits, GitHub, GitLab) Commit: 8d9f6ab9f7b9f1a7526bb41f70259be74f53b32c
Dependencies: Stopgaps:

Status badges

Description (last modified by klui)

Line 394 is part of the definition for the intersection method but it said

raise TypeError("only addition of two finite subgroups is defined")

This should be changed to

raise TypeError("only intersection with a finite subgroup or "
        "modular abelian variety is defined")

Change History (7)

comment:1 Changed 5 years ago by klui

  • Description modified (diff)

comment:2 Changed 5 years ago by klui

  • Branch set to u/klui/fixing_a_typo_in_error_message_within_finite_subgroups_of_modular_abelian_varieties

comment:3 Changed 5 years ago by klui

  • Authors set to Kevin Lui
  • Commit set to 8d9f6ab9f7b9f1a7526bb41f70259be74f53b32c
  • Status changed from new to needs_review

New commits:

8d9f6abfixed an error message in finite_subgroup.py

comment:4 Changed 5 years ago by klui

  • Description modified (diff)

comment:5 Changed 5 years ago by jmantysalo

Seems good, but when you are working with this, can also the note "TODO: Intersection, action of Hecke operators." at the beginning now be removed?

comment:6 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be..

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/klui/fixing_a_typo_in_error_message_within_finite_subgroups_of_modular_abelian_varieties to 8d9f6ab9f7b9f1a7526bb41f70259be74f53b32c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.