Opened 5 years ago

Closed 4 years ago

#22773 closed enhancement (fixed)

Add random Stone lattice

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-8.0
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a2d87de (Commits, GitHub, GitLab) Commit: a2d87defac6fc38fccd71953c02a08129c3d9b88
Dependencies: #22145 Stopgaps:

Status badges

Description

This patch will add a function to generate random Stone lattice.

Not meaningfull until #22145 is closed.

Change History (13)

comment:1 Changed 5 years ago by jmantysalo

  • Branch set to u/jmantysalo/random-stone

comment:2 Changed 5 years ago by jmantysalo

  • Commit set to f2bfdb249a2791d49233255bc753b5a0de7732de
  • Dependencies set to #22145
  • Status changed from new to needs_review

New commits:

999f56aAdd random Stone lattice.
f2bfdb2Spaces removed.

comment:3 Changed 5 years ago by git

  • Commit changed from f2bfdb249a2791d49233255bc753b5a0de7732de to 096f1c5781b4bfd10fc1711c1b81a4ccdab598cd

Branch pushed to git repo; I updated commit sha1. New commits:

096f1c5Merge branch 'develop' into t/22773/random-stone

comment:4 Changed 5 years ago by jmantysalo

This should work now.

(Got error when compiling lcalc, even after make distclean. So untested code in principle.)

comment:5 follow-up: Changed 5 years ago by tscrim

(See sage-release for the lcalc issue.)

comment:6 in reply to: ↑ 5 Changed 5 years ago by jmantysalo

Replying to tscrim:

(See sage-release for the lcalc issue.)

(Thanks. After patch -R the compilation continues.)

comment:7 Changed 5 years ago by git

  • Commit changed from 096f1c5781b4bfd10fc1711c1b81a4ccdab598cd to 8548f0ceae68db1d3d81c362fd1241927f32ea44

Branch pushed to git repo; I updated commit sha1. New commits:

8548f0cAdd check for a property combination.

comment:8 Changed 5 years ago by jmantysalo

Found a slight bug. Now everything seems to be fine.

comment:9 Changed 4 years ago by jmantysalo

Just pinging.

comment:10 follow-up: Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

(as DiGraph) -> (as a digraph) or (as a :class:DiGraph?). Otherwise LGTM and you can set a positive review on my behalf after making the change.

Last edited 4 years ago by tscrim (previous) (diff)

comment:11 Changed 4 years ago by git

  • Commit changed from 8548f0ceae68db1d3d81c362fd1241927f32ea44 to a2d87defac6fc38fccd71953c02a08129c3d9b88

Branch pushed to git repo; I updated commit sha1. New commits:

a2d87deAdd 'a'.

comment:12 in reply to: ↑ 10 Changed 4 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Replying to tscrim:

(as DiGraph) -> (as a digraph) or (as a :class:DiGraph?). Otherwise LGTM and you can set a positive review on my behalf after making the change.

Done that. Thanks.

comment:13 Changed 4 years ago by vbraun

  • Branch changed from u/jmantysalo/random-stone to a2d87defac6fc38fccd71953c02a08129c3d9b88
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.