Opened 5 years ago
Closed 5 years ago
#22772 closed defect (fixed)
Matplotlib: don't write ascii as binary in make-setup-config.py
Reported by: | jhpalmieri | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.0 |
Component: | packages: standard | Keywords: | |
Cc: | Merged in: | ||
Authors: | John Palmieri | Reviewers: | François Bissey |
Report Upstream: | N/A | Work issues: | |
Branch: | 79ab0ea (Commits, GitHub, GitLab) | Commit: | 79ab0ea8f95f9c2766f5d2cf595344a3c5846f06 |
Dependencies: | Stopgaps: |
Description
Sage's script make-setup-config.py, used in installing matplotlib, writes an ascii file as binary. This is not a good idea, and can lead to trouble when building matplotlib with python 3 on OS X.
Change History (4)
comment:1 Changed 5 years ago by
- Branch set to u/jhpalmieri/matplotlib-make-setup-config
comment:2 Changed 5 years ago by
- Commit set to 79ab0ea8f95f9c2766f5d2cf595344a3c5846f06
- Status changed from new to needs_review
comment:3 Changed 5 years ago by
- Reviewers set to François Bissey
- Status changed from needs_review to positive_review
Ha, this is a sage specific file! I was wondering why I couldn't see anything in my build logs for the gentoo package. Jeroen would make you bump the version but I am happy to let it go.
comment:4 Changed 5 years ago by
- Branch changed from u/jhpalmieri/matplotlib-make-setup-config to 79ab0ea8f95f9c2766f5d2cf595344a3c5846f06
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
trac 22772: in build/pkgs/matplotlib/make-setup-config.py, don't use