Opened 6 years ago

Closed 6 years ago

#22770 closed defect (fixed)

Fix functools32 spkg-install

Reported by: John Palmieri Owned by:
Priority: critical Milestone: sage-8.0
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: Jeroen Demeyer, John Palmieri, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: b5679b7 (Commits, GitHub, GitLab) Commit: b5679b7f14530962c6f7a92d5c24d2282bb99e55
Dependencies: Stopgaps:

Status badges

Description (last modified by John Palmieri)

The spkg-install script for functools32 uses -n for a not operator; it should instead use !.

Before the fix, I see this in the log file:

./spkg-install: line 9: [: -x: binary operator expected

This error is ignored, and indeed, the whole if block is ignored.

Change History (12)

comment:1 Changed 6 years ago by John Palmieri

Branch: u/jhpalmieri/functools

comment:2 Changed 6 years ago by John Palmieri

Commit: 8b4ee00dce6faa43eed6ac2e7ca1b4c41b673fff
Status: newneeds_review

New commits:

8b4ee00trac 22770: change "-n" to "!" in functools32 spkg-install

comment:3 Changed 6 years ago by John Palmieri

Description: modified (diff)

comment:4 Changed 6 years ago by John Palmieri

Description: modified (diff)

comment:5 Changed 6 years ago by John Palmieri

Description: modified (diff)

comment:6 Changed 6 years ago by Jeroen Demeyer

Reviewers: Jeroen Demeyer
Status: needs_reviewpositive_review

comment:7 Changed 6 years ago by git

Commit: 8b4ee00dce6faa43eed6ac2e7ca1b4c41b673fffb5679b7f14530962c6f7a92d5c24d2282bb99e55
Status: positive_reviewneeds_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

b5679b7trac 22770: don't install functools32 if SAGE_PYTHON3=yes

comment:8 Changed 6 years ago by John Palmieri

Status: needs_reviewneeds_work

comment:9 Changed 6 years ago by John Palmieri

Status: needs_workneeds_review

The proposed change in #22582 is better, especially since we now install both python 2 and python 3 by default. Here is a branch with just that change, or we can see if #22582 gets positively reviewed, in which case this will be a duplicate.

comment:10 Changed 6 years ago by John Palmieri

Authors: John PalmieriVolker Braun
Reviewers: Jeroen DemeyerJeroen Demeyer, John Palmieri
Status: needs_reviewpositive_review

This is from Volker's branch at #22582, and I am willing to give it a positive review, plus Frédéric positively reviewed this change before.

Last edited 6 years ago by John Palmieri (previous) (diff)

comment:11 Changed 6 years ago by John Palmieri

Reviewers: Jeroen Demeyer, John PalmieriJeroen Demeyer, John Palmieri, Frédéric Chapoton

comment:12 Changed 6 years ago by Volker Braun

Branch: u/jhpalmieri/functoolsb5679b7f14530962c6f7a92d5c24d2282bb99e55
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.