Opened 5 years ago

Closed 5 years ago

#22770 closed defect (fixed)

Fix functools32 spkg-install

Reported by: jhpalmieri Owned by:
Priority: critical Milestone: sage-8.0
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: Jeroen Demeyer, John Palmieri, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: b5679b7 (Commits, GitHub, GitLab) Commit: b5679b7f14530962c6f7a92d5c24d2282bb99e55
Dependencies: Stopgaps:

Status badges

Description (last modified by jhpalmieri)

The spkg-install script for functools32 uses -n for a not operator; it should instead use !.

Before the fix, I see this in the log file:

./spkg-install: line 9: [: -x: binary operator expected

This error is ignored, and indeed, the whole if block is ignored.

Change History (12)

comment:1 Changed 5 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/functools

comment:2 Changed 5 years ago by jhpalmieri

  • Commit set to 8b4ee00dce6faa43eed6ac2e7ca1b4c41b673fff
  • Status changed from new to needs_review

New commits:

8b4ee00trac 22770: change "-n" to "!" in functools32 spkg-install

comment:3 Changed 5 years ago by jhpalmieri

  • Description modified (diff)

comment:4 Changed 5 years ago by jhpalmieri

  • Description modified (diff)

comment:5 Changed 5 years ago by jhpalmieri

  • Description modified (diff)

comment:6 Changed 5 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:7 Changed 5 years ago by git

  • Commit changed from 8b4ee00dce6faa43eed6ac2e7ca1b4c41b673fff to b5679b7f14530962c6f7a92d5c24d2282bb99e55
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

b5679b7trac 22770: don't install functools32 if SAGE_PYTHON3=yes

comment:8 Changed 5 years ago by jhpalmieri

  • Status changed from needs_review to needs_work

comment:9 Changed 5 years ago by jhpalmieri

  • Status changed from needs_work to needs_review

The proposed change in #22582 is better, especially since we now install both python 2 and python 3 by default. Here is a branch with just that change, or we can see if #22582 gets positively reviewed, in which case this will be a duplicate.

comment:10 Changed 5 years ago by jhpalmieri

  • Authors changed from John Palmieri to Volker Braun
  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, John Palmieri
  • Status changed from needs_review to positive_review

This is from Volker's branch at #22582, and I am willing to give it a positive review, plus Frédéric positively reviewed this change before.

Last edited 5 years ago by jhpalmieri (previous) (diff)

comment:11 Changed 5 years ago by jhpalmieri

  • Reviewers changed from Jeroen Demeyer, John Palmieri to Jeroen Demeyer, John Palmieri, Frédéric Chapoton

comment:12 Changed 5 years ago by vbraun

  • Branch changed from u/jhpalmieri/functools to b5679b7f14530962c6f7a92d5c24d2282bb99e55
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.