Opened 5 years ago

Closed 2 years ago

#22760 closed enhancement (fixed)

Add support for __matmul__ in the coercion model

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-9.2
Component: python3 Keywords:
Cc: jpflori, embray, tscrim, egourgoulhon, gh-mjungmath Merged in:
Authors: Jeroen Demeyer, Matthias Koeppe Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d939b2c (Commits, GitHub, GitLab) Commit: d939b2cee7f1992745c11cb3440729b519833e19
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Python 3.5 added the infix matrix multiplication operator PEP 465.

This ticket adds support for it in the coercion model.

The infix matrix multiplication operator (@) could be used for matrix and tensor multiplication.

Follow-up: #30244

Change History (20)

comment:1 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Add support for __matmul__ in the coercion model to Add support for __matmul__ in preparser and the coercion model

comment:2 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Add support for __matmul__ in preparser and the coercion model to Add support for __matmul__ in the coercion model

comment:3 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/add_support_for___matmul___in_the_coercion_model

comment:4 Changed 5 years ago by jdemeyer

  • Commit set to 4f62e6fc707dc3a2e9edbeaa4dd2f7ca24f3d004
  • Status changed from new to needs_review

New commits:

4f62e6fAdd support for __matmul__ in the coercion model

comment:5 Changed 5 years ago by jpflori

  • Cc jpflori added

comment:6 Changed 5 years ago by embray

  • Cc embray added

comment:7 Changed 5 years ago by chapoton

  • Status changed from needs_review to needs_work

does not apply

comment:8 Changed 5 years ago by jdemeyer

chapton: do you actually care about this ticket? I don't plan to fix a ticket if nobody looks at it anyway.

comment:9 Changed 4 years ago by embray

  • Milestone changed from sage-8.0 to sage-wishlist

This will still be good to have eventually. I wonder if we could also backport matmul support to Python 2 in the Sage pre-parser...

comment:10 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-wishlist to sage-9.2

comment:11 Changed 2 years ago by mkoeppe

  • Cc tscrim added

comment:12 Changed 2 years ago by mkoeppe

  • Branch changed from u/jdemeyer/add_support_for___matmul___in_the_coercion_model to u/mkoeppe/add_support_for___matmul___in_the_coercion_model

comment:13 Changed 2 years ago by mkoeppe

  • Commit changed from 4f62e6fc707dc3a2e9edbeaa4dd2f7ca24f3d004 to ea74b6ffc5d7d50e62bb95065c41da4ffe73888c
  • Description modified (diff)

New commits:

ea74b6fAdd support for __matmul__ in the coercion model

comment:14 Changed 2 years ago by mkoeppe

  • Cc egourgoulhon gh-mjungmath added
  • Description modified (diff)

comment:15 Changed 2 years ago by git

  • Commit changed from ea74b6ffc5d7d50e62bb95065c41da4ffe73888c to d939b2cee7f1992745c11cb3440729b519833e19

Branch pushed to git repo; I updated commit sha1. New commits:

d939b2cUpdate doctests for py3

comment:16 Changed 2 years ago by mkoeppe

  • Authors changed from Jeroen Demeyer to Jeroen Demeyer, Matthias Koeppe
  • Status changed from needs_work to needs_review

comment:17 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

We can now include this in. Yay.

comment:18 Changed 2 years ago by mkoeppe

Thank you!

comment:19 Changed 2 years ago by mkoeppe

  • Description modified (diff)

comment:20 Changed 2 years ago by vbraun

  • Branch changed from u/mkoeppe/add_support_for___matmul___in_the_coercion_model to d939b2cee7f1992745c11cb3440729b519833e19
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.