Opened 5 years ago

Closed 5 years ago

#22759 closed enhancement (fixed)

ComplexDoubleElement.algdep(): use arith.misc.algdep

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: basic arithmetic Keywords:
Cc: dimpase, embray Merged in:
Authors: Dima Pasechnik Reviewers: Jeroen Demeyer, Erik Bray
Report Upstream: N/A Work issues:
Branch: fd96c0a (Commits, GitHub, GitLab) Commit: fd96c0aaf7e0aa999a95b6bfe1baff54e23234cd
Dependencies: #22714 Stopgaps:

Status badges

Description


Change History (12)

comment:1 Changed 5 years ago by jdemeyer

  • Dependencies set to #22714

comment:2 Changed 5 years ago by jdemeyer

Remind me to work on this once #22714 has been merged (to avoid conflicts with other tickets).

comment:3 Changed 5 years ago by dimpase

  • Authors changed from Jeroen Demeyer to Jeroen Demeyer, Dima Pasechnik
  • Branch set to u/dimpase/t22759
  • Commit set to 08b18621a359afd669d82d5e0dcf9c0b0e98d29f
  • Status changed from new to needs_review

let's just get it done :-)


New commits:

2f6afb2Define __abs__ for p-adic numbers
65ab385Factorize result of algdep()
08b1862fix for #22759

comment:4 Changed 5 years ago by dimpase

well, wrong git base, but 08b1862 does the job.

comment:5 Changed 5 years ago by jdemeyer

  • Authors changed from Jeroen Demeyer, Dima Pasechnik to Dima Pasechnik

The branch is already red...

comment:6 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

comment:7 Changed 5 years ago by embray

  • Cc embray added

This would probably fix #21605, but I need to double-check.

comment:8 Changed 5 years ago by git

  • Commit changed from 08b18621a359afd669d82d5e0dcf9c0b0e98d29f to fd96c0aaf7e0aa999a95b6bfe1baff54e23234cd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e53c199Merge branch 'u/jdemeyer/factorize_result_of_algdep__' of trac.sagemath.org:sage into dcfix
fd96c0afix for #22759

comment:9 Changed 5 years ago by dimpase

  • Status changed from needs_work to needs_review

rebased over the the branch of #22714 needs review; passes tests on linux and freebsd

comment:10 Changed 5 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:11 Changed 5 years ago by embray

  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, Erik Bray

Confirmed that this fixes #21605 on Cygwin as well.

comment:12 Changed 5 years ago by vbraun

  • Branch changed from u/dimpase/t22759 to fd96c0aaf7e0aa999a95b6bfe1baff54e23234cd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.