Opened 5 years ago

Closed 5 years ago

#22758 closed enhancement (fixed)

Crosslink DisjointSet and SetPartition

Reported by: jmantysalo Owned by:
Priority: trivial Milestone: sage-8.0
Component: documentation Keywords:
Cc: slabbe, tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 36842ca (Commits, GitHub, GitLab) Commit: 36842caeba4cb1fded555989ddc280d8b29d130f
Dependencies: Stopgaps:

Status badges

Description

Add links DisjointSet? <-> SetPartition?.

Change History (10)

comment:1 Changed 5 years ago by jmantysalo

  • Branch set to u/jmantysalo/crosslink-setpartitions

comment:2 Changed 5 years ago by jmantysalo

  • Commit set to c4ef75ccd97d95d57a85af9dc4ec6921e7251948
  • Status changed from new to needs_info

Sphinx again... What's wrong this time? A :class: reference to .pyx does not work?


New commits:

c4ef75cAdd crosslinks.

comment:3 follow-up: Changed 5 years ago by tscrim

It's not imported into the global namespace, so you have to do the full path.

comment:4 in reply to: ↑ 3 Changed 5 years ago by jmantysalo

Replying to tscrim:

It's not imported into the global namespace, so you have to do the full path.

But function DisjointSet() is, and I tried also to link it with :meth: without success.

comment:5 follow-up: Changed 5 years ago by tscrim

That is because it is a function, not a method. did you try :func:?

comment:6 Changed 5 years ago by git

  • Commit changed from c4ef75ccd97d95d57a85af9dc4ec6921e7251948 to 36842caeba4cb1fded555989ddc280d8b29d130f

Branch pushed to git repo; I updated commit sha1. New commits:

36842caWorking link.

comment:7 in reply to: ↑ 5 Changed 5 years ago by jmantysalo

  • Status changed from needs_info to needs_review

Replying to tscrim:

That is because it is a function, not a method. did you try :func:?

Have you seen brains on sale? I would like to buy one.

comment:8 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Mine is for sale. It just costs one beer. :P

comment:9 Changed 5 years ago by slabbe

Thanks for the patch and review!

comment:10 Changed 5 years ago by vbraun

  • Branch changed from u/jmantysalo/crosslink-setpartitions to 36842caeba4cb1fded555989ddc280d8b29d130f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.