Opened 3 years ago

Closed 3 years ago

#22754 closed enhancement (fixed)

order and chain polytopes are defined over ZZ

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: combinatorics Keywords: polytope
Cc: jplabbe, jmantysalo, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: 9fe4db4 (Commits) Commit: 9fe4db4c4801ce4ddd4370b3b355183212156717
Dependencies: Stopgaps:

Description

Currently, order_polytope and chain_polytope of posets return polytopes over QQ. They can be enhanced to return polytopes over ZZ.

This allows to compute their Ehrhart polynomial, for example.

Change History (10)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/22754
  • Cc jplabbe jmantysalo tscrim added
  • Commit set to 6e427159bb5c32634bb37374202720e22ba31c3c
  • Status changed from new to needs_review

New commits:

07d53b5py3: wrap some "map" with "list"
6e42715posets: order and chain polytopes over ZZ

comment:2 Changed 3 years ago by git

  • Commit changed from 6e427159bb5c32634bb37374202720e22ba31c3c to 9aeefb1612b860beef8d30b658a322d1407389cd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9aeefb1posets: order and chain polytopes over ZZ

comment:3 Changed 3 years ago by jipilab

Indeed, they are.

The patch looks fine to me.

comment:4 Changed 3 years ago by jipilab

  • Status changed from needs_review to positive_review

There is only one thing: the polyhedron are given with the H-representation... but indeed, the vertices are integers in the end...

So I guess it is good to go...

comment:5 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name...

comment:6 Changed 3 years ago by jipilab

  • Reviewers set to Jean-Philippe Labbé
  • Status changed from needs_work to positive_review

comment:7 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

See patchbot

comment:8 Changed 3 years ago by git

  • Commit changed from 9aeefb1612b860beef8d30b658a322d1407389cd to 9fe4db4c4801ce4ddd4370b3b355183212156717

Branch pushed to git repo; I updated commit sha1. New commits:

1efb4bdMerge branch 'u/chapoton/22754' in 8.0.b1
9fe4db4trac 22754 fixing one doctest

comment:9 Changed 3 years ago by chapoton

  • Status changed from needs_work to positive_review

trivial doctest correction done, setting back to positive

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/22754 to 9fe4db4c4801ce4ddd4370b3b355183212156717
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.