Opened 4 years ago

Closed 4 years ago

#22753 closed defect (fixed)

Don't declare functions/methods as "cdef inline"

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 94302ca (Commits, GitHub, GitLab) Commit: 94302cabcce3c932af9660f709911fd20dab12e5
Dependencies: Stopgaps:

Status badges

Description

Declaring (as opposed to implementing) functions/methods as inline makes no sense. Cython currently allows it, but it is known to have issues (including generating invalid C code and breaking with Cython updates).

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/don_t_declare_functions_methods_as__cdef_inline_

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 94302cabcce3c932af9660f709911fd20dab12e5
  • Status changed from new to needs_review

New commits:

94302caDo not declare functions/methods as "cdef inline"

comment:3 Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/don_t_declare_functions_methods_as__cdef_inline_ to 94302cabcce3c932af9660f709911fd20dab12e5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.