Opened 5 years ago

Closed 5 years ago

#22749 closed enhancement (fixed)

py3: some care for map again

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.0
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6d3a8d4 (Commits, GitHub, GitLab) Commit: 6d3a8d4acff68d6d00a9d6cf5e83b2b5067645f4
Dependencies: Stopgaps:

Status badges

Description

Handle some map in the doctests that should be wrapped with list, for python3 compatibility.

Change History (5)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/22749
  • Commit set to 07d53b568514d8c222e5c23b038261d23964bf5e
  • Status changed from new to needs_review

New commits:

​07d53b5py3: wrap some "map" with "list"

comment:2 Changed 5 years ago by tscrim

  • Branch changed from u/chapoton/22749 to u/tscrim/map_care-22749
  • Commit changed from 07d53b568514d8c222e5c23b038261d23964bf5e to 6d3a8d4acff68d6d00a9d6cf5e83b2b5067645f4
  • Reviewers set to Travis Scrimshaw

I changed a few of them to use generator expressions.

New commits:

​6d3a8d4Using generators instead of list(map(f, L)).

comment:3 Changed 5 years ago by chapoton

ok, looks good to me. You can set to positive if you want.

comment:4 Changed 5 years ago by tscrim

  • Status changed from needs_review to positive_review

Thanks.

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/tscrim/map_care-22749 to 6d3a8d4acff68d6d00a9d6cf5e83b2b5067645f4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.