Opened 5 years ago

Closed 2 months ago

#22747 closed enhancement (invalid)

(experimental) Compile Cython code with binding=True

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: cython Keywords:
Cc: klee Merged in:
Authors: Jeroen Demeyer Reviewers: Michael Orlitzky
Report Upstream: Reported upstream. No feedback yet. Work issues:
Branch: u/jdemeyer/ticket/22747 (Commits, GitHub, GitLab) Commit: d9620409749338b4c33aeef1ded7c944d74e10dd
Dependencies: #25842, #25845, #25848 Stopgaps:

Status badges

Description (last modified by jdemeyer)

When using the Cython compiler directive binding=True, Cython uses a custom type to implement functions and methods. This custom type supports more Python features. The most important changes lie in inspect support.

We find several Cython bugs regarding binding=True:

Change History (38)

comment:1 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/22747

comment:3 Changed 5 years ago by git

  • Commit set to 2b7032755d9be33a994b0c612860f8dd93dfbe74

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2b70327Compile Cython code with binding=True

comment:4 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 5 years ago by jdemeyer

  • Dependencies changed from #21682 to #21843

comment:6 Changed 5 years ago by git

  • Commit changed from 2b7032755d9be33a994b0c612860f8dd93dfbe74 to 547397b9ae95d4522e98278f67f93ac999077562

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​b56b4beInclude Cython directives in .cython_version file
​547397bCompile Cython code with binding=True

comment:7 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

comment:8 Changed 5 years ago by git

  • Commit changed from 547397b9ae95d4522e98278f67f93ac999077562 to ee13351f71508d3d4990ca308807d1629f4616f3

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ee13351Compile Cython code with binding=True

comment:9 Changed 5 years ago by jdemeyer

  • Dependencies changed from #21843 to #21843, #22852

comment:10 Changed 5 years ago by git

  • Commit changed from ee13351f71508d3d4990ca308807d1629f4616f3 to 93250a2559ca15185e31fb2386ff869a8b4022b8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​841676dDefine functions before calling them
​8994aceMerge commit '841676d4931c9f59019b2b6b82afbbe7df222c10' into t/22747/ticket/22747
​93250a2Compile Cython code with binding=True

comment:11 Changed 5 years ago by git

  • Commit changed from 93250a2559ca15185e31fb2386ff869a8b4022b8 to 1e783146c63be6ba12a99e051fa5e22f94cbcd68

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​1e78314Compile Cython code with binding=True

comment:12 Changed 5 years ago by jdemeyer

  • Dependencies #21843, #22852 deleted

comment:13 Changed 5 years ago by git

  • Commit changed from 1e783146c63be6ba12a99e051fa5e22f94cbcd68 to e62cc3abc980536e24f3645ffedd958a5d528d19

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​a57b913QuotientRing_nc.ideal(): use super() instead of CommutativeRing
​e62cc3aCompile Cython code with binding=True

comment:14 Changed 5 years ago by jdemeyer

  • Dependencies set to #23103
  • Description modified (diff)

comment:15 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:16 Changed 5 years ago by git

  • Commit changed from e62cc3abc980536e24f3645ffedd958a5d528d19 to 680f4a75b456709688f70943b6e0de18770b6560

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​256bf19Move richcmp stuff to new file richcmp.pyx
​7629851Merge tag '8.0.beta9' into t/23103/move_richcmp_stuff_to_new_file
​031761fFix two more imports
​f159d41Add Cython patch to fix decorators with binding=True
​680f4a7Compile Cython code with binding=True

comment:17 Changed 5 years ago by jdemeyer

  • Dependencies changed from #23103 to #23103, #23122

comment:18 Changed 5 years ago by git

  • Commit changed from 680f4a75b456709688f70943b6e0de18770b6560 to b24e4c88cfe2b8226fce171689f2daf0bf99fcc0

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​d59afe3Load the correct zlib library
​db3b5ebMerge commit '031761f6ead116e4fa0a0fd3bf21fca5546df6d7' into HEAD
​4c5cc9cAdd Cython patch to fix decorators with binding=True
​116030bCompile Cython code with binding=True
​b24e4c8Sage library fixes for binding=True

comment:19 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:20 Changed 5 years ago by jdemeyer

  • Dependencies changed from #23103, #23122 to #23103, #23122, #23155, #15947
  • Description modified (diff)

comment:21 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:22 Changed 5 years ago by jdemeyer

  • Dependencies changed from #23103, #23122, #23155, #15947 to #23103, #23122, #23155, #15947, #23159

comment:23 Changed 5 years ago by git

  • Commit changed from b24e4c88cfe2b8226fce171689f2daf0bf99fcc0 to 37975ed8814027132d3eacaa1bb31cc4cacedce6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2e2339bAdd Cython patch to fix decorators with binding=True
​091657dAdd Cython patch to fix method calls with binding=True
​8f29430_lmul_ and _rmul_: scalar should be Element instead of RingElement
​d288f41Give deprecation warning for #5930 unconditionally
​6bd7e9fMerge commit '031761f6ead116e4fa0a0fd3bf21fca5546df6d7'; commit 'd59afe3bf4ee03da91184ae6183a6dd6a9d3656f'; commit '091657d270e422bfc7f27efa7d6944a5c3fd96f2'; commit '8f294308f8b85b233ffdc9df3f20c404ee6431c9'; commit 'd288f414bf0f8d785c1928fd1bdce89ec1bdc033' into HEAD
​8ebd184Compile Cython code with binding=True
​37975edSage library fixes for binding=True

comment:24 Changed 4 years ago by git

  • Commit changed from 37975ed8814027132d3eacaa1bb31cc4cacedce6 to 90e7db1ee59509c25a9542f12cbaef11205a99f5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​8a5bb48Compile Cython code with binding=True
​90e7db1Sage library fixes for binding=True

comment:25 Changed 4 years ago by git

  • Commit changed from 90e7db1ee59509c25a9542f12cbaef11205a99f5 to 4062ec68cca650a62e107a109b9cea64cfcc2041

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​4062ec6Sage library fixes for binding=True

comment:26 Changed 4 years ago by git

  • Commit changed from 4062ec68cca650a62e107a109b9cea64cfcc2041 to dba0dd66ddcb13f04413f62fca0081c12c2d4afd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​94ab6e0Compile Cython code with binding=True
​dba0dd6Sage library fixes for binding=True

comment:27 Changed 4 years ago by jdemeyer

  • Dependencies #23103, #23122, #23155, #15947, #23159 deleted

comment:28 Changed 4 years ago by git

  • Commit changed from dba0dd66ddcb13f04413f62fca0081c12c2d4afd to 0f70aed1913168af02274d7aa98fc7d885342bc6

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​f1debe3Upgrade to Cython 0.28.4
​ee4c6c4Compile Cython code with binding=True
​aa3513fSage library fixes for binding=True
​0f70aedTry to fix Set_PythonType

comment:29 Changed 4 years ago by git

  • Commit changed from 0f70aed1913168af02274d7aa98fc7d885342bc6 to 60007d507004bcf1e364bc44bbc1f3871b4d523d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​6310172Fix a cyclic import involving interval fields
​60007d5Move Set_PythonType to a new file

comment:30 Changed 4 years ago by git

  • Commit changed from 60007d507004bcf1e364bc44bbc1f3871b4d523d to 13068eb1685533f688f2d5b817a79667ade7d1a1

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​13068ebMove Set_PythonType to a new file

comment:31 Changed 4 years ago by jdemeyer

  • Dependencies set to #25845

comment:32 Changed 4 years ago by git

  • Commit changed from 13068eb1685533f688f2d5b817a79667ade7d1a1 to ddb7cc8dce2d0162779903c772bb7e3b8d2f7207

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​7e7daefMove Set_PythonType to a new file
​48f170fCompile Cython code with binding=True
​46a7887Sage library fixes for binding=True
​ddb7cc8Fix a cyclic import involving interval fields

comment:33 Changed 4 years ago by git

  • Commit changed from ddb7cc8dce2d0162779903c772bb7e3b8d2f7207 to 5282f127ff9e10ec071d4bbbf47eebbec057ca93

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​8756c40Some preparations for binding=True
​5282f12Sage library fixes for binding=True

comment:34 Changed 4 years ago by git

  • Commit changed from 5282f127ff9e10ec071d4bbbf47eebbec057ca93 to d9620409749338b4c33aeef1ded7c944d74e10dd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​742e1c9Some preparations for binding=True
​c5a8bd3Compile Cython code with binding=True
​d962040Sage library fixes for binding=True

comment:35 Changed 4 years ago by jdemeyer

  • Dependencies changed from #25845 to #25842, #25845, #25848

comment:36 Changed 4 months ago by mkoeppe

  • Cc klee added
  • Milestone changed from sage-8.0 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

We can close this ticket in favor of #26254.

The only commit from the branch here that is useful is ​https://github.com/sagemath/sagetrac-mirror/commit/d9620409749338b4c33aeef1ded7c944d74e10dd -- not really "Sage library fixes" but just some updates of doctest outputs.

comment:37 Changed 2 months ago by mjo

  • Reviewers set to Michael Orlitzky
  • Status changed from needs_review to positive_review

Ok, #26254 looks much further along.

comment:38 Changed 2 months ago by mkoeppe

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.