Opened 5 years ago

Closed 5 years ago

#22745 closed enhancement (fixed)

LatticePoset: "antidoubling", part 3

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-8.0
Component: combinatorics Keywords:
Cc: mantepse, tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 13abce1 (Commits, GitHub, GitLab) Commit: 13abce13aad6b3b7b570b5f030a210198520fb36
Dependencies: Stopgaps:

Status badges

Description (last modified by jmantysalo)

This patch adds a function to recognize if a lattice can be constructed by Day doubling constructions of any (possible) subsets. (Also adds "interface" for #22693.) The code may be unoptimal. For those who want to think:

Change History (13)

comment:1 Changed 5 years ago by jmantysalo

  • Branch set to u/jmantysalo/latticeposet___antidoubling___part_3

comment:2 Changed 5 years ago by jmantysalo

  • Cc mantepse tscrim added
  • Commit set to 8c4a3df506fe7f0fde88134cac9b29c053e98259
  • Description modified (diff)
  • Status changed from new to needs_review

Ready for review.

New commits:

​8c4a3dfAdd more tests for being doubling constructible.

comment:3 Changed 5 years ago by git

  • Commit changed from 8c4a3df506fe7f0fde88134cac9b29c053e98259 to 48fb811834e464c4cc0524ca6f2648e4dc0aec74

Branch pushed to git repo; I updated commit sha1. New commits:

​48fb811Merge branch 'develop' into t/22745/latticeposet___antidoubling___part_3

comment:4 Changed 5 years ago by jmantysalo

Martin? This is quite direct implementation.

Long note in the decription is not needed for review.

comment:5 Changed 5 years ago by git

  • Commit changed from 48fb811834e464c4cc0524ca6f2648e4dc0aec74 to 87d58c25308c9e6e4610569b44241d8ee20e591a

Branch pushed to git repo; I updated commit sha1. New commits:

​87d58c2Add a test.

comment:6 Changed 5 years ago by jmantysalo

  • Description modified (diff)

I got an answer from Tristan Holmes. There are lattices that have congruence lattice having both maximal chains satisfying and not satisfying the needed property. Hence the code can not be easily optimized.

(There is room for optimization -- not all congruences are always needed to compute -- but that's a different story.)

comment:7 Changed 5 years ago by git

  • Commit changed from 87d58c25308c9e6e4610569b44241d8ee20e591a to 74af0fe2d80022a1ce553b469c78b247fcc61560

Branch pushed to git repo; I updated commit sha1. New commits:

​74af0feMerge branch 'develop' into t/22745/latticeposet___antidoubling___part_3

comment:8 Changed 5 years ago by jmantysalo

Travis, can you look at this?

(I think that after this, maybe in July, I want to make a code for doing the decomposition. Not sure if it should be a certificate for this or another function. Anyways, congruence-related functions are almost done now.)

comment:9 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

One little this: 

-                if e_up not in reachable:
-                    if splitting_depth_2(e, e_up):
+                if e_up not in reachable and splitting_depth_2(e, e_up):

Otherwise LGTM.

comment:10 Changed 5 years ago by git

  • Commit changed from 74af0fe2d80022a1ce553b469c78b247fcc61560 to 13abce13aad6b3b7b570b5f030a210198520fb36

Branch pushed to git repo; I updated commit sha1. New commits:

​13abce1From if-if to if-and.

comment:11 Changed 5 years ago by jmantysalo

If ...: ... if changed to if ... and ...:.

comment:12 Changed 5 years ago by tscrim

  • Status changed from needs_review to positive_review

Thanks.

comment:13 Changed 5 years ago by vbraun

  • Branch changed from u/jmantysalo/latticeposet___antidoubling___part_3 to 13abce13aad6b3b7b570b5f030a210198520fb36
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.