Opened 5 years ago

Closed 5 years ago

#22729 closed enhancement (fixed)

Expose some internal variables computed in hecke_series

Reported by: mmasdeu Owned by:
Priority: major Milestone: sage-8.0
Component: modular forms Keywords: overconvergent,
Cc: davidloeffler Merged in:
Authors: Marc Masdeu Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: aa3e71f (Commits, GitHub, GitLab) Commit: aa3e71fda2926a11883dcf24a568637f2d4f86f9
Dependencies: Stopgaps:

Status badges


This ticket exposes (by turning on a flag) certain nontrivial data computed in the hecke_series which is currently hidden from the user. This may be (is) useful in other applications of A.Lauder's code.

Change History (9)

comment:1 Changed 5 years ago by mmasdeu

  • Branch set to u/mmasdeu/22729-improve-hecke-series
  • Cc davidloeffler added
  • Commit set to 7774636bccb7975aca5659acabdd2a20bf332240
  • Status changed from new to needs_review

New commits:

21e5565Fixed bug when lifting p-automorphic forms of weight > 2.
ffcc45fAdded doctest to show that bug is fixed.
7774636Exposed intermediate data computed in some functions which is useful in other applications.

comment:2 Changed 5 years ago by chapoton

  • Branch changed from u/mmasdeu/22729-improve-hecke-series to public/22729
  • Commit changed from 7774636bccb7975aca5659acabdd2a20bf332240 to f42be53b8e0f7f594a077c4e67157ffa653123e8
  • Reviewers set to Frédéric Chapoton

I made a cosmetic review commit.

If you agree with my changes, you can set to "positive review" in my name.

New commits:

7e139a8Merge branch 'u/mmasdeu/22729-improve-hecke-series' in 8.0.b2
f42be53trac 22729 some doc details and code formatting

comment:3 Changed 5 years ago by git

  • Commit changed from f42be53b8e0f7f594a077c4e67157ffa653123e8 to aa3e71fda2926a11883dcf24a568637f2d4f86f9

Branch pushed to git repo; I updated commit sha1. New commits:

aa3e71ftrac 22729 more doc and code details

comment:4 Changed 5 years ago by chapoton

I made another cosmetic commit, as I had forgotten to do half of the job.

comment:5 Changed 5 years ago by chapoton

a question: in the second function

+      the integers ``elldash`` and ``mdash``.

shouldn't elldash be ell ?

comment:6 follow-up: Changed 5 years ago by chapoton

ping ? is there anybody out there ?

comment:7 in reply to: ↑ 6 Changed 5 years ago by mmasdeu

Oops, I think that the email got buried among others...

I still think that it should say what it says. The integer ell can be deduced from the size of the matrices in Alist...

Thank you for looking into this!

Replying to chapoton:

ping ? is there anybody out there ?

comment:8 Changed 5 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, then

comment:9 Changed 5 years ago by vbraun

  • Branch changed from public/22729 to aa3e71fda2926a11883dcf24a568637f2d4f86f9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.