Opened 5 years ago
Closed 4 years ago
#22674 closed enhancement (fixed)
Add irreducibles_poset()
Reported by: | jmantysalo | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.0 |
Component: | combinatorics | Keywords: | |
Cc: | tscrim | Merged in: | |
Authors: | Jori Mäntysalo | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 7c6ae98 (Commits, GitHub, GitLab) | Commit: | 7c6ae9895d1a54453de2f1035a7a82087da2f092 |
Dependencies: | Stopgaps: |
Description
This patch will add a function that gives the smallest subposet having completion by cuts isomorphic to the lattice. (I.e. the poset of meet- and join- (or both) irreducibles, except the one-element lattice.)
Change History (11)
comment:1 Changed 5 years ago by
- Branch set to u/jmantysalo/irreducibles-poset
comment:2 Changed 5 years ago by
- Cc tscrim added
- Commit set to 70735593e6a41dd11a0fbff0d7eabc6d110ebfa8
- Status changed from new to needs_review
comment:3 follow-up: ↓ 5 Changed 5 years ago by
- Status changed from needs_review to needs_work
Let's wait for #22867.
comment:4 Changed 4 years ago by
- Commit changed from 70735593e6a41dd11a0fbff0d7eabc6d110ebfa8 to 7c6ae9895d1a54453de2f1035a7a82087da2f092
comment:5 in reply to: ↑ 3 Changed 4 years ago by
- Status changed from needs_work to needs_review
comment:6 follow-up: ↓ 7 Changed 4 years ago by
Is this still true?
Due to implementation detail in Sage, actually isomorphic to the dual of the lattice.
comment:7 in reply to: ↑ 6 Changed 4 years ago by
Replying to tscrim:
Is this still true?
Due to implementation detail in Sage, actually isomorphic to the dual of the lattice.
No, not anymore. You reviewed the ticket that changed completion_by_cuts()
.
comment:8 follow-up: ↓ 9 Changed 4 years ago by
That is what I was thinking, so it should be removed. Otherwise LGTM.
comment:9 in reply to: ↑ 8 Changed 4 years ago by
Replying to tscrim:
That is what I was thinking, so it should be removed. Otherwise LGTM.
?? I already did that, see commit 7c6ae98.
comment:10 Changed 4 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
Whoops. Missed that.
comment:11 Changed 4 years ago by
- Branch changed from u/jmantysalo/irreducibles-poset to 7c6ae9895d1a54453de2f1035a7a82087da2f092
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Add irreducibles_poset().