Opened 5 years ago

Closed 4 years ago

#22674 closed enhancement (fixed)

Add irreducibles_poset()

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-8.0
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7c6ae98 (Commits, GitHub, GitLab) Commit: 7c6ae9895d1a54453de2f1035a7a82087da2f092
Dependencies: Stopgaps:

Status badges

Description

This patch will add a function that gives the smallest subposet having completion by cuts isomorphic to the lattice. (I.e. the poset of meet- and join- (or both) irreducibles, except the one-element lattice.)

Change History (11)

comment:1 Changed 5 years ago by jmantysalo

  • Branch set to u/jmantysalo/irreducibles-poset

comment:2 Changed 5 years ago by jmantysalo

  • Cc tscrim added
  • Commit set to 70735593e6a41dd11a0fbff0d7eabc6d110ebfa8
  • Status changed from new to needs_review

New commits:

7073559Add irreducibles_poset().

comment:3 follow-up: Changed 5 years ago by jmantysalo

  • Status changed from needs_review to needs_work

Let's wait for #22867.

comment:4 Changed 4 years ago by git

  • Commit changed from 70735593e6a41dd11a0fbff0d7eabc6d110ebfa8 to 7c6ae9895d1a54453de2f1035a7a82087da2f092

Branch pushed to git repo; I updated commit sha1. New commits:

47ed2fbMerge branch 'develop' into t/22674/irreducibles-poset
7c6ae98Correction as #22867 is now done.

comment:5 in reply to: ↑ 3 Changed 4 years ago by jmantysalo

  • Status changed from needs_work to needs_review

Replying to jmantysalo:

Let's wait for #22867.

This done, so I put this to needs_review.

comment:6 follow-up: Changed 4 years ago by tscrim

Is this still true?

Due to implementation detail in Sage, actually isomorphic to the dual of the lattice.

comment:7 in reply to: ↑ 6 Changed 4 years ago by jmantysalo

Replying to tscrim:

Is this still true?

Due to implementation detail in Sage, actually isomorphic to the dual of the lattice.

No, not anymore. You reviewed the ticket that changed completion_by_cuts().

comment:8 follow-up: Changed 4 years ago by tscrim

That is what I was thinking, so it should be removed. Otherwise LGTM.

comment:9 in reply to: ↑ 8 Changed 4 years ago by jmantysalo

Replying to tscrim:

That is what I was thinking, so it should be removed. Otherwise LGTM.

?? I already did that, see commit 7c6ae98.

comment:10 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Whoops. Missed that.

comment:11 Changed 4 years ago by vbraun

  • Branch changed from u/jmantysalo/irreducibles-poset to 7c6ae9895d1a54453de2f1035a7a82087da2f092
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.