Opened 4 years ago

Closed 3 years ago

#22669 closed defect (fixed)

Three.js: add aspect_ratio multipliers to text3d

Reported by: paulmasson Owned by:
Priority: major Milestone: sage-8.0
Component: graphics Keywords:
Cc: novoselt, egourgoulhon Merged in:
Authors: Paul Masson Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: 1d10aa0 (Commits) Commit: 1d10aa0ea344ad48748409cfa0dd8e8fbe4a8c37
Dependencies: Stopgaps:

Description

The multipliers entered using the aspect_ratio keyword are currently not applied to the positions of text3d objects. This is a simple fix that can be tested with the graphics object

sum([text3d('%.1f'%n, (cos(n),sin(n),n), viewer='threejs') for n in [0,0.2,..,8]])

because the viewer has automatic scaling in the z-direction that is not applied to the spiral of numbers.

Change History (4)

comment:1 Changed 4 years ago by paulmasson

  • Branch set to u/paulmasson/22669

comment:2 Changed 4 years ago by paulmasson

  • Cc novoselt egourgoulhon added
  • Commit set to 1d10aa0ea344ad48748409cfa0dd8e8fbe4a8c37
  • Status changed from new to needs_review

Keep in mind that changes to the non-Python template require make even with git trac try


New commits:

1d10aa0Add missing aspect multipliers

comment:3 Changed 4 years ago by egourgoulhon

  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to positive_review

LGTM. Thanks for the fix!

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/paulmasson/22669 to 1d10aa0ea344ad48748409cfa0dd8e8fbe4a8c37
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.