Opened 5 years ago
Closed 5 years ago
#22662 closed enhancement (fixed)
Fold farey.pxd into farey_symbol.pyx
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage8.0 
Component:  cython  Keywords:  
Cc:  embray  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  8e5db1e (Commits, GitHub, GitLab)  Commit:  8e5db1e2dccb61de366439d6da285b56a14f4d9c 
Dependencies:  Stopgaps: 
Description (last modified by )
Unlike other .pxd
files, the file farey.pxd
is not meant as public header. For this reason, we move its contents to the file farey_symbol.pyx
, which is the only place where it is used.
We also fix a typo __deallocpp__
causing a memory leak.
Change History (10)
comment:1 Changed 5 years ago by
 Description modified (diff)
comment:2 Changed 5 years ago by
 Branch set to u/jdemeyer/ticket/22662
comment:3 Changed 5 years ago by
 Commit set to 1dd577194a4aa73d7366e2a6a4b5b97d3b06ee00
 Status changed from new to needs_review
comment:4 followup: ↓ 8 Changed 5 years ago by
 Status changed from needs_review to needs_work
sage t long src/sage_setup/find.py # 1 doctest failed
comment:5 Changed 5 years ago by
 Commit changed from 1dd577194a4aa73d7366e2a6a4b5b97d3b06ee00 to 8e5db1e2dccb61de366439d6da285b56a14f4d9c
Branch pushed to git repo; I updated commit sha1. New commits:
8e5db1e  Change test

comment:6 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:7 Changed 5 years ago by
 Cc embray added
comment:8 in reply to: ↑ 4 Changed 5 years ago by
Replying to chapoton:
sage t long src/sage_setup/find.py # 1 doctest failed
Fixed, patchbot looks good now.
comment:9 Changed 5 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, let it be
comment:10 Changed 5 years ago by
 Branch changed from u/jdemeyer/ticket/22662 to 8e5db1e2dccb61de366439d6da285b56a14f4d9c
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Fold farey.pxd into farey_symbol.pyx