Opened 6 years ago

Last modified 5 years ago

#22661 new enhancement

Doctest, raise warning limit for # long time -tests

Reported by: Jori Mäntysalo Owned by:
Priority: minor Milestone: sage-8.0
Component: doctest framework Keywords:
Cc: David Roe, Samuel Lelièvre Merged in:
Authors: Jori Mäntysalo Reviewers:
Report Upstream: N/A Work issues:
Branch: u/jmantysalo/test-long-warn (Commits, GitHub, GitLab) Commit: c5d90462ed44d7c15cbb0b8a21dd0991b6112ff9
Dependencies: Stopgaps:

Status badges

Description (last modified by Samuel Lelièvre)

Sage's doctesting framework gives warnings about doctests taking longer than expected to complete.

These warnings should not be triggered as easily for tests and examples marked # long time.

This example code multiplies time limit to 10-fold for those. Real code should probably have an option for that, or --warn-long should accept a pair of real numbers.

Change History (3)

comment:1 Changed 6 years ago by Jori Mäntysalo

Branch: u/jmantysalo/test-long-warn

comment:2 Changed 5 years ago by Samuel Lelièvre

Cc: Samuel Lelièvre added
Commit: c5d90462ed44d7c15cbb0b8a21dd0991b6112ff9
Description: modified (diff)

Edited ticket description: fix a typo + minor rephrasing for clarity. Feel free to revert if I betrayed the intended meaning.


New commits:

c5d9046An example: 10-fold warning limit.

comment:3 in reply to:  description Changed 5 years ago by Jeroen Demeyer

Replying to jmantysalo:

These warnings should not be triggered as easily for tests and examples marked # long time.

I would argue that, if you don't want to see --warn-long warnings for # long time doctests, you should adjust the --warn-long argument accordingly.

In any case, I don't like the totally arbitrary 10x factor.

Note: See TracTickets for help on using tickets.