Opened 5 years ago

Closed 5 years ago

#22660 closed enhancement (fixed)

Drop latex_memory.patch

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: packages: standard Keywords:
Cc: fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey, John Palmieri
Report Upstream: N/A Work issues:
Branch: dd85361 (Commits, GitHub, GitLab) Commit: dd853615c366ba447fe436c8ae96acaa329408d0
Dependencies: #22252 Stopgaps:

Status badges

Description (last modified by jdemeyer)

Some people claim that the Sphinx patch latex_memory.patch is no longer needed. We should check whether we can drop that patch.

Test carefully before mindlessly setting this to positive review

Change History (10)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/22660

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to dd853615c366ba447fe436c8ae96acaa329408d0
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

879c401Upgrade to Sphinx 1.5.3
78e6718Docbuild fixes for Sphinx 1.5.x
ced4920Allow running Sphinx without SSL
67f3b42Add missing patches back
f20f00aUse TeX package iftex
dd85361Drop latex_memory.patch

comment:3 Changed 5 years ago by jdemeyer

  • Dependencies set to #22252

comment:4 follow-up: Changed 5 years ago by fbissey

And someone other than me should test it for confirmation.

comment:5 in reply to: ↑ 4 ; follow-up: Changed 5 years ago by jdemeyer

Replying to fbissey:

And someone other than me should test it for confirmation.

Can you please detail on which system you tested this?

comment:6 Changed 5 years ago by jhpalmieri

Builds for me on OS X 10.12, 16GB RAM, TeXLive 2016, as long as I use LC_ALL=C make doc-pdf.

comment:7 in reply to: ↑ 5 Changed 5 years ago by fbissey

Replying to jdemeyer:

Replying to fbissey:

And someone other than me should test it for confirmation.

Can you please detail on which system you tested this?

Linux Gentoo.

comment:8 Changed 5 years ago by jdemeyer

I'm inclined to say that Linux Gentoo and OS X are sufficiently different to consider this ticket good to go.

comment:9 Changed 5 years ago by jdemeyer

  • Reviewers set to François Bissey, John Palmieri
  • Status changed from needs_review to positive_review

comment:10 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/22660 to dd853615c366ba447fe436c8ae96acaa329408d0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.