Opened 4 years ago

Closed 4 years ago

#22644 closed defect (fixed)

Fix and test interact library

Reported by: kcrisman Owned by:
Priority: major Milestone: sage-8.0
Component: interact Keywords: days86
Cc: kcrisman Merged in:
Authors: Jeroen Demeyer Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 9cfe2aa (Commits, GitHub, GitLab) Commit: 9cfe2aaec9ba1db8644e5d1dafb11cd7eb07e0fb
Dependencies: #22636, #22664 Stopgaps:

Status badges

Description (last modified by jdemeyer)

Fix the ​the interacts library

  1. Make it work in Jupyter.
  1. Define html(obj) as pretty_print(html(obj)) to fix lots of naked html results, sort of (printed rather than shown MathJax?).
  1. Fix issues which prevent certain interacts from running.
  1. Actually test that the interacts work in Jupyter (currently, the code only checks that the interact is displayed, it does not test execution).

Change History (23)

comment:1 Changed 4 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Dependencies set to #22636
  • Description modified (diff)
  • Summary changed from Fix html() references without pretty_print in interacts library to Fix and test interact library

comment:2 Changed 4 years ago by jdemeyer

  • Dependencies changed from #22636 to #22636, #22664

comment:3 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/fix_and_test_interact_library

comment:4 Changed 4 years ago by jdemeyer

  • Cc kcrisman added
  • Commit set to 803c78d68a64b8ff4bee198eccd0c2b7ee71adf3
  • Dependencies changed from #22636, #22664 to #22636, #22664, #22665
  • Description modified (diff)

New commits:

​d6747ddsage_wraps: add f attribute to return wrapped function
​0d0b149Make interact library compatible with Jupyter
​cc924cfMerge commit '0d0b1492867859af17df1418c2331be287025bf8' into t/22644/fix_and_test_interact_library
​803c78dFix and test interact library

comment:5 Changed 4 years ago by jdemeyer

  • Dependencies changed from #22636, #22664, #22665 to #22636, #22664

comment:6 Changed 4 years ago by git

  • Commit changed from 803c78d68a64b8ff4bee198eccd0c2b7ee71adf3 to 9b4d47e9de8839a2d3a5d5beffeda3f6f94a948f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​9b4d47eFix and test interact library

comment:7 Changed 4 years ago by jdemeyer

  • Status changed from new to needs_review

comment:8 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:9 follow-up: Changed 4 years ago by jdemeyer

Does anybody actually care about this ticket...?

comment:10 Changed 4 years ago by git

  • Commit changed from 9b4d47e9de8839a2d3a5d5beffeda3f6f94a948f to ebae1c8a4d60122a9b4340110ff25953199e050f

Branch pushed to git repo; I updated commit sha1. New commits:

​ebae1c8Merge tag '8.0.beta2' into t/22644/fix_and_test_interact_library

comment:11 in reply to: ↑ 9 Changed 4 years ago by kcrisman

Does anybody actually care about this ticket...?

Yes, but not everyone who does has infinite time available to review it.

comment:12 follow-up: Changed 4 years ago by jdemeyer

Sorry, I meant no offense.

I hope that you understand how it can be frustrating to work on something and then get no feedback.

comment:13 Changed 4 years ago by git

  • Commit changed from ebae1c8a4d60122a9b4340110ff25953199e050f to 9b4d47e9de8839a2d3a5d5beffeda3f6f94a948f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:14 Changed 4 years ago by jdemeyer

Merge conflict solved on #22664.

comment:15 in reply to: ↑ 12 Changed 4 years ago by kcrisman

I hope that you understand how it can be frustrating to work on something and then get no feedback.

Oh yes I very much understand this, and I hope you are likewise not offended that some are just impossible to get to.

I am also frustrated that I do not have enough time to work on any Sage stuff but the ones I know will cause the most annoyance to other users and no one else will worry about - currently that is the Mac app on Sage 8.0. This is already broken so although I want to get to it I know it's not likely in the next week.

:-(

comment:16 Changed 4 years ago by slabbe

  • Status changed from needs_review to needs_work

the branch has conflicts

comment:17 Changed 4 years ago by git

  • Commit changed from 9b4d47e9de8839a2d3a5d5beffeda3f6f94a948f to 7168721b604a68352dba654ac0daa51275284efb

Branch pushed to git repo; I updated commit sha1. New commits:

​b72155dMerge tag '8.0.beta2' into t/22664/sage_wraps__add_f_attribute_to_return_wrapped_function
​7168721Merge commit 'b72155dc1cf0c0eb063dafc578a022beff2d9a14' into t/22644/fix_and_test_interact_library

comment:18 Changed 4 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:19 Changed 4 years ago by jdemeyer

The conflict was really in the dependency #22664, so I merged that.

comment:20 Changed 4 years ago by slabbe

  • Keywords days86 added
  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

It works. I also checked that it still works in sagenb.

comment:21 Changed 4 years ago by git

  • Commit changed from 7168721b604a68352dba654ac0daa51275284efb to 9cfe2aaec9ba1db8644e5d1dafb11cd7eb07e0fb
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​9cfe2aaMerge tag '8.0.beta3' into t/22644/fix_and_test_interact_library

comment:22 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

Merged with latest beta.

comment:23 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/fix_and_test_interact_library to 9cfe2aaec9ba1db8644e5d1dafb11cd7eb07e0fb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.