Opened 3 years ago

Closed 5 months ago

#22640 closed enhancement (duplicate)

Fix checking python site-packages

Reported by: isuruf Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: Merged in:
Authors: Isuru Fernando Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: u/isuruf/site (Commits) Commit: b05089cf3393e022b5e5563e057d28cbd5b02536
Dependencies: Stopgaps:

Description


Change History (10)

comment:1 Changed 3 years ago by isuruf

  • Component changed from PLEASE CHANGE to build
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

Patched in conda, arch, debian. Makes the life of the next packager easier.

comment:2 Changed 3 years ago by isuruf

  • Branch set to u/isuruf/site

comment:3 Changed 3 years ago by vbraun

  • Commit set to b96d602276cdb625937b70df37bdfe3ca13cc2ab
  • Reviewers set to Volker Braun

LGTM, please set to positive review after you put your name in the Authors field.


New commits:

b96d602Fix checking python site-packages

comment:4 Changed 3 years ago by isuruf

  • Authors set to Isuru Fernando
  • Status changed from needs_review to positive_review

comment:5 Changed 3 years ago by jdemeyer

  • Status changed from positive_review to needs_work

This will break when more than version of Python has Sage installed, right? Given that there seems to be a push to do precisely that, I'm not sure that this is the right fix.

Last edited 3 years ago by jdemeyer (previous) (diff)

comment:6 Changed 3 years ago by vbraun

True, test handles multiple files in the least helpful way:

$ test -d local/lib/python*/site-packages
bash: test: too many arguments

comment:7 Changed 3 years ago by git

  • Commit changed from b96d602276cdb625937b70df37bdfe3ca13cc2ab to b05089cf3393e022b5e5563e057d28cbd5b02536

Branch pushed to git repo; I updated commit sha1. New commits:

b05089cFix for multiple python

comment:8 Changed 3 years ago by isuruf

#22764 does the same thing. Can be closed

comment:9 Changed 5 months ago by isuruf

  • Milestone changed from sage-8.0 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

comment:10 Changed 5 months ago by jdemeyer

  • Resolution set to duplicate
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.