Opened 4 years ago

Closed 4 years ago

#22636 closed enhancement (fixed)

Make the Sage interact library work in Jupyter

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.0
Component: notebook Keywords: days86
Cc: kcrisman Merged in:
Authors: Jeroen Demeyer Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 0d0b149 (Commits) Commit: 0d0b1492867859af17df1418c2331be287025bf8
Dependencies: Stopgaps:

Description

Apparently, Sage has an "interacts library" in src/sage/interacts. This should work in Jupyter too.

Attachments (3)

after.png​ (138.9 KB) - added by slabbe 4 years ago.
before.png​ (118.6 KB) - added by slabbe 4 years ago.
interacts.png​ (88.3 KB) - added by jdemeyer 4 years ago.
How it should look

Download all attachments as: .zip

Change History (16)

comment:1 follow-up: Changed 4 years ago by kcrisman

  • Dependencies set to #22644

Possible dependency noted for this to work properly.

comment:2 in reply to: ↑ 1 Changed 4 years ago by jdemeyer

  • Dependencies #22644 deleted

Replying to kcrisman:

Possible dependency noted for this to work properly.

I think this ticket should be about making it work at all. Fixing bugs with the interact library can be done in follow-up tickets like #22644.

comment:3 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/make_the_sage_interact_library_work_in_jupyter

comment:4 Changed 4 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 103ca3f3d1d48da29ad9d6e26ccebd753c8e1b6d
  • Status changed from new to needs_review

New commits:

​103ca3fMake interact library compatible with Jupyter

comment:5 Changed 4 years ago by git

  • Commit changed from 103ca3f3d1d48da29ad9d6e26ccebd753c8e1b6d to 0d0b1492867859af17df1418c2331be287025bf8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​0d0b149Make interact library compatible with Jupyter

Changed 4 years ago by slabbe

Changed 4 years ago by slabbe

comment:6 Changed 4 years ago by slabbe

  • Status changed from needs_review to needs_info

This is what I see with 7.6.rc2:

This is what I see with 7.6.rc2 + #22636:

Therefore, I can not conclude that the actual description of this ticket is achieved, i.e., that interact library "work in Jupyter". Or maybe this ticket's goal is something else like getting to an intermediate state before #22644?

What is the goal of this ticket? Does the above picture shows that this goal is achieved?

comment:7 Changed 4 years ago by slabbe

  • Keywords days86 added

comment:8 Changed 4 years ago by jdemeyer

  • Status changed from needs_info to needs_work

I swear that this worked when I wrote the code. I'll need to check what is going wrong.

Changed 4 years ago by jdemeyer

How it should look

comment:9 Changed 4 years ago by jdemeyer

  • Status changed from needs_work to needs_review

It works for me (an actual interact is displayed), see interacts.png​.

Could you please double-check that you properly built Sage (i.e. make or make build worked without errors)?

comment:10 Changed 4 years ago by jdemeyer

If it still doesn't work, maybe try merging 8.0.beta2 and check again.

comment:11 follow-up: Changed 4 years ago by slabbe

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

Works on top of 8.0.beta2. Positive review.

I will open a ticket to update interacts.calculus.newton_method() which prints lot of deprecation warnings.

comment:12 in reply to: ↑ 11 Changed 4 years ago by slabbe

I will open a ticket to update interacts.calculus.newton_method() which prints lot of deprecation warnings.

see #22845

comment:13 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/make_the_sage_interact_library_work_in_jupyter to 0d0b1492867859af17df1418c2331be287025bf8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.