Opened 2 years ago
Closed 2 years ago
#22635 closed defect (duplicate)
Pari tests broken on Cygwin
| Reported by: | embray | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
| Component: | porting: Cygwin | Keywords: | windows cygwin pari |
| Cc: | Merged in: | ||
| Authors: | Erik Bray | Reviewers: | |
| Report Upstream: | Fixed upstream, but not in a stable release. | Work issues: | |
| Branch: | u/embray/cygwin/pari-stdin (Commits) | Commit: | dba51d95c19b45071651eed757376de33685677d |
| Dependencies: | Stopgaps: |
Description (last modified by )
The test suite for Pari itself (e.g. make test-all) is broken on Cygwin. Each test is given as a file containing commands that is piped to gp's stdin. However, it exits prematurely after reading just a few lines of each test.
The attached patch fixes the issue. I didn't update the patch level on the package version yet, since it would conflict with #22633 (which is higher priority to fix first).
Upstream bug: https://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1913
Change History (10)
comment:1 Changed 2 years ago by
comment:2 Changed 2 years ago by
- Report Upstream changed from N/A to Not yet reported upstream; Will do shortly.
Right, definitely.
comment:3 Changed 2 years ago by
Do you want me to report this upstream?
comment:4 Changed 2 years ago by
- Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.
comment:5 Changed 2 years ago by
- Description modified (diff)
comment:6 in reply to: ↑ description Changed 2 years ago by
Replying to embray:
The attached patch fixes the issue. I didn't update the patch level on the package version yet, since it would conflict with #22633 (which is higher priority to fix first).
Since the patches are rather simple, maybe it's easier to add both patches on the same ticket (say, #22633)?
comment:7 Changed 2 years ago by
That would be pointless as there are already separate tickets and the issues are unrelated.
comment:8 Changed 2 years ago by
Beware of #22675: we might need to synchronize these tickets.
comment:9 Changed 2 years ago by
- Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.
comment:10 Changed 2 years ago by
- Milestone changed from sage-8.0 to sage-duplicate/invalid/wontfix
- Resolution set to duplicate
- Status changed from new to closed
I will add the patch to #22675.
The patch obviously makes sense but it should be reported upstream.