Opened 5 years ago
Closed 5 years ago
#22629 closed enhancement (fixed)
Implement more generic code for (finite dimensional) modules with basis
Reported by:  tscrim  Owned by:  

Priority:  major  Milestone:  sage8.0 
Component:  categories  Keywords:  days85 
Cc:  nthiery  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  2fa5862 (Commits, GitHub, GitLab)  Commit:  2fa58623e4231d49fff7ba0e570ab3043e00abc5 
Dependencies:  Stopgaps: 
Description
On #22623, I was writing a number of methods that were generic for (finite dimensional) modules with basis that should be put into the category. These include:
_from_dict
dimension
_dense_free_module
_vector_
Change History (10)
comment:1 Changed 5 years ago by
 Branch set to public/categories/more_generic_module_with_basis_methods22629
 Commit set to de071c1b670aeab40b4d6eba39b651bc458257b2
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
failing doctests, see bot
comment:3 Changed 5 years ago by
 Commit changed from de071c1b670aeab40b4d6eba39b651bc458257b2 to 72a8366d2ae60ba5158851c2ff402dea052b7e74
comment:4 Changed 5 years ago by
Fixed. One error was due to a typo. The errors in the Schur algebras were exposing that they and their tensor modules were not placed in the correct category. I also reverted a change to CombinatorialFreeModuleElement._vector_
to avoid conflicts with #22632.
comment:5 Changed 5 years ago by
Patchbot is green. Should be a relatively simple review.
comment:6 Changed 5 years ago by
 Commit changed from 72a8366d2ae60ba5158851c2ff402dea052b7e74 to 2fa58623e4231d49fff7ba0e570ab3043e00abc5
Branch pushed to git repo; I updated commit sha1. New commits:
18ddbb7  Merge branch 'develop' into public/categories/more_generic_module_with_basis_methods22629

a5502ff  Merge branch 'develop' into public/categories/more_generic_module_with_basis_methods22629

814c9e0  Merge branch 'develop' into public/categories/more_generic_module_with_basis_methods22629

74aa5da  Merge branch 'develop' into public/categories/more_generic_module_with_basis_methods22629

2fa5862  Adding from_vector to the category.

comment:7 Changed 5 years ago by
Patchbot is (essentially) green and this does not conflict with #22632.
comment:8 Changed 5 years ago by
is the vector.iteritems python3safe ?
EDIT It seems so, indeed, as a method of vectors.
comment:9 Changed 5 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, looks good.
comment:10 Changed 5 years ago by
 Branch changed from public/categories/more_generic_module_with_basis_methods22629 to 2fa58623e4231d49fff7ba0e570ab3043e00abc5
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Added/lifted more methods to (finite dimensional) free modules.