Opened 5 years ago

Closed 5 years ago

#22629 closed enhancement (fixed)

Implement more generic code for (finite dimensional) modules with basis

Reported by: tscrim Owned by:
Priority: major Milestone: sage-8.0
Component: categories Keywords: days85
Cc: nthiery Merged in:
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 2fa5862 (Commits, GitHub, GitLab) Commit: 2fa58623e4231d49fff7ba0e570ab3043e00abc5
Dependencies: Stopgaps:

Status badges

Description

On #22623, I was writing a number of methods that were generic for (finite dimensional) modules with basis that should be put into the category. These include:

  • _from_dict
  • dimension
  • _dense_free_module
  • _vector_

Change History (10)

comment:1 Changed 5 years ago by tscrim

  • Branch set to public/categories/more_generic_module_with_basis_methods-22629
  • Commit set to de071c1b670aeab40b4d6eba39b651bc458257b2
  • Status changed from new to needs_review

New commits:

​de071c1Added/lifted more methods to (finite dimensional) free modules.

comment:2 Changed 5 years ago by chapoton

failing doctests, see bot

comment:3 Changed 5 years ago by git

  • Commit changed from de071c1b670aeab40b4d6eba39b651bc458257b2 to 72a8366d2ae60ba5158851c2ff402dea052b7e74

Branch pushed to git repo; I updated commit sha1. New commits:

​d70ee67Fixing typo in doctest output.
​d5f1426Reverting change to the element class to avoid conflicts with #22632.
​72a8366Putting Schur algebras and the tensor modules in the correct category.

comment:4 Changed 5 years ago by tscrim

Fixed. One error was due to a typo. The errors in the Schur algebras were exposing that they and their tensor modules were not placed in the correct category. I also reverted a change to CombinatorialFreeModuleElement._vector_ to avoid conflicts with #22632.

comment:5 Changed 5 years ago by tscrim

Patchbot is green. Should be a relatively simple review.

comment:6 Changed 5 years ago by git

  • Commit changed from 72a8366d2ae60ba5158851c2ff402dea052b7e74 to 2fa58623e4231d49fff7ba0e570ab3043e00abc5

Branch pushed to git repo; I updated commit sha1. New commits:

​18ddbb7Merge branch 'develop' into public/categories/more_generic_module_with_basis_methods-22629
​a5502ffMerge branch 'develop' into public/categories/more_generic_module_with_basis_methods-22629
​814c9e0Merge branch 'develop' into public/categories/more_generic_module_with_basis_methods-22629
​74aa5daMerge branch 'develop' into public/categories/more_generic_module_with_basis_methods-22629
​2fa5862Adding from_vector to the category.

comment:7 Changed 5 years ago by tscrim

Patchbot is (essentially) green and this does not conflict with #22632.

comment:8 Changed 5 years ago by chapoton

is the vector.iteritems python3-safe ?

EDIT It seems so, indeed, as a method of vectors.

Last edited 5 years ago by chapoton (previous) (diff)

comment:9 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good.

comment:10 Changed 5 years ago by vbraun

  • Branch changed from public/categories/more_generic_module_with_basis_methods-22629 to 2fa58623e4231d49fff7ba0e570ab3043e00abc5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.