Opened 5 years ago
Closed 5 years ago
#22624 closed enhancement (fixed)
little cleanup of Dokchister lfunction file
| Reported by: | chapoton | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-8.0 |
| Component: | number theory | Keywords: | |
| Cc: | jmantysalo | Merged in: | |
| Authors: | Frédéric Chapoton | Reviewers: | Jori Mäntysalo |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 4357298 (Commits, GitHub, GitLab) | Commit: | 4357298f06560468df3fd321829d82987d2a09d2 |
| Dependencies: | Stopgaps: |
Status badges
Description
plus one added example : Dedekind zeta of a number field
Change History (8)
comment:1 Changed 5 years ago by
- Branch set to u/chapoton/22624
- Commit set to 4357298f06560468df3fd321829d82987d2a09d2
- Status changed from new to needs_review
comment:3 Changed 5 years ago by
- Status changed from needs_review to needs_info
Seems good, but if you return 1.10398438736918 in a doctest, it seems like a real number. Is it guarenteed to work without any precision definition?
comment:4 follow-up: ↓ 5 Changed 5 years ago by
well, the precision is fixed at a default value, I think
anyway, none of the similar doctests in the same file are decorated by # abs tol
comment:5 in reply to: ↑ 4 Changed 5 years ago by
- Status changed from needs_info to positive_review
Replying to chapoton:
well, the precision is fixed at a default value, I think
anyway, none of the similar doctests in the same file are decorated by
# abs tol
OK then.
comment:7 Changed 5 years ago by
- Reviewers set to Jori Mäntysalo
- Status changed from needs_work to positive_review
done
comment:8 Changed 5 years ago by
- Branch changed from u/chapoton/22624 to 4357298f06560468df3fd321829d82987d2a09d2
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
little cleanup of dokchister lfunction file