Changes between Version 8 and Version 23 of Ticket #22611
- Timestamp:
- 03/23/17 20:36:21 (4 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #22611
-
Property
Status
changed from
needs_review
topositive_review
-
Property
Reviewers
changed from
to
Erik Bray
-
Property
Commit
changed from
fa42d8eb1966a7e1ade67bb40b42a80bb04059b1
to5fe7cb01a8cd117ac6754c8301fb5ddf94d82813
-
Property
Status
changed from
-
Ticket #22611 – Description
v8 v23 3 3 I tried various ways of implementing this and I found several Cython bugs along the way. The current solution is not the cleanest, but it works in all cases (Cython and Python, extension types and normal classes). 4 4 5 In the cases where `_sage_doc_` was implemented for a base class, this patch requires adding `@ InstanceDoc` to every subclass. This is because Python never inherits the `__doc__` attribute. There is a way around this using a metaclass, but I avoided that because metaclasses have their own problems (see #21681).5 In the cases where `_sage_doc_` was implemented for a base class, this patch requires adding `@instancedoc` to every subclass. This is because Python never inherits the `__doc__` attribute. There is a way around this using a metaclass, but I avoided that because metaclasses have their own problems (see #21681).