Opened 5 years ago
Closed 5 years ago
#22609 closed enhancement (fixed)
Remove set_coercion_model()
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.6 |
Component: | coercion | Keywords: | days85 |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 25d5471 (Commits, GitHub, GitLab) | Commit: | 25d54714ad22586f98741160d9c82b440a7f73d1 |
Dependencies: | Stopgaps: |
Description
See https://groups.google.com/forum/#!topic/sage-devel/Zjea7Gnx_wE for discussion.
Nobody is using set_coercion_model
and removing it can simplify and speed up some code.
Change History (5)
comment:1 Changed 5 years ago by
- Branch set to u/jdemeyer/remove_set_coercion_model__
comment:2 Changed 5 years ago by
- Commit set to e38222e9cce5ff1553ecf318f7325d7c7d6964a5
- Status changed from new to needs_review
comment:3 Changed 5 years ago by
- Commit changed from e38222e9cce5ff1553ecf318f7325d7c7d6964a5 to 25d54714ad22586f98741160d9c82b440a7f73d1
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
25d5471 | Remove set_coercion_model; add coercion_model global
|
comment:4 Changed 5 years ago by
- Keywords days85 added
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
comment:5 Changed 5 years ago by
- Branch changed from u/jdemeyer/remove_set_coercion_model__ to 25d54714ad22586f98741160d9c82b440a7f73d1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Not tested yet. Setting to needs_review for the patchbot.
New commits:
Remove set_coercion_model; add coercion_model global