Opened 6 years ago

Closed 5 years ago

#22584 closed defect (fixed)

Debug build doctests fail with sig_block() with sig_on_count = 1, block_sigint = 1

Reported by: Volker Braun Owned by:
Priority: major Milestone: sage-7.6
Component: packages: standard Keywords: cysignals
Cc: Jeroen Demeyer Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 4394a22 (Commits, GitHub, GitLab) Commit: 4394a22ef16c6e7934c2c6b318c0ad594fec7d29
Dependencies: Stopgaps:

Status badges

Description

Lots of doctests fail in a SAGE_DEBUG=yes build similar to:

File "src/sage/schemes/elliptic_curves/ell_number_field.py", line 578, in sage.schemes.elliptic_curves.ell_number_field.EllipticCurve_number_field.height_pairing_matrix
Failed example:
    E.regulator_of_points([P,Q])
Expected:
    0.164101403936070
Got:
    <BLANKLINE>
    *** WARNING *** sig_block() with sig_on_count = 1, block_sigint = 1
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/cysignals/signals.so(+0x4558)[0x7f0e6622f558]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/libs/cypari2/stack.so(+0x2357)[0x7f0e59e96357]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/libs/cypari2/stack.so(+0x2b0c)[0x7f0e59e96b0c]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/libs/cypari2/stack.so(+0x255b)[0x7f0e59e9655b]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/libs/cypari2/stack.so(+0x2923)[0x7f0e59e96923]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/libs/cypari2/handle_error.so(+0x63a3)[0x7f0e59a7f3a3]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpari-gmp.so.5(pari_err+0x15c)[0x7f0e65e19efd]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpari-gmp.so.5(+0x284239)[0x7f0e65c14239]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpari-gmp.so.5(checkell_Fq+0x5b)[0x7f0e65c14c90]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpari-gmp.so.5(ellorder+0x18a)[0x7f0e65c5415c]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/libs/cypari2/gen.so(+0x70ca3)[0x7f0e5a320ca3]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/libs/cypari2/gen.so(+0x708fa)[0x7f0e5a3208fa]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyCFunction_Call+0xbc)[0x7f0e731d5ba0]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(+0x162813)[0x7f0e73281813]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0xb8ce)[0x7f0e7327bdbe]
    /mnt/disk/home/buildslave-sage/slave/sage_git/build/local/lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x113f)[0x7f0e7327ed28]

Change History (7)

comment:1 Changed 6 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer

comment:2 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/debug_build_doctests_fail_with_sig_block___with_sig_on_count___1__block_sigint___1

comment:3 Changed 6 years ago by Jeroen Demeyer

Commit: 4394a22ef16c6e7934c2c6b318c0ad594fec7d29
Status: newneeds_review

Volker: please merge this in the next beta. The plan is to split off src/sage/libs/cypari2 as a separate package and I would like to do this on top of 8.0.beta0


New commits:

4394a22Only wrap pari_err2str() in sig_block()

comment:4 Changed 6 years ago by Jeroen Demeyer

This fixes most errors of this form, but not all. There is still an issue in closure.pyx. But that will require changes to cysignals itself, so the fix is not so simple.

comment:5 Changed 6 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

comment:6 Changed 6 years ago by Vincent Delecroix

Is there an issue open in cysignals?

comment:7 Changed 5 years ago by Volker Braun

Branch: u/jdemeyer/debug_build_doctests_fail_with_sig_block___with_sig_on_count___1__block_sigint___14394a22ef16c6e7934c2c6b318c0ad594fec7d29
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.