Opened 4 years ago

Closed 4 years ago

#22568 closed enhancement (fixed)

Polyhedron_ZZ should inherit from Polyhedron_QQ, not Polyhedron_base

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-7.6
Component: geometry Keywords: days84
Cc: jipilab, vdelecroix Merged in:
Authors: Matthias Koeppe Reviewers: Jean-Philippe Labbé
Report Upstream: N/A Work issues:
Branch: 67eb1d7 (Commits, GitHub, GitLab) Commit: 67eb1d7e74c7eaa0bf640550cdf60160a7a893ef
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

This is so we can define methods that require rational data in Polyhedron_QQ, and they will become available to polyhedra defined with integral data.

Change History (10)

comment:1 Changed 4 years ago by mkoeppe

  • Branch set to u/mkoeppe/polyhedron_zz_should_inherit_from_polyhedron_qq__not_polyhedron_base

comment:2 Changed 4 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 67eb1d7e74c7eaa0bf640550cdf60160a7a893ef
  • Status changed from new to needs_review

New commits:

67eb1d7Change Polyhedron_ZZ to inherit from Polyhedron_QQ, not Polyhedron_base

comment:3 Changed 4 years ago by mkoeppe

  • Description modified (diff)

comment:4 Changed 4 years ago by jipilab

  • Reviewers set to Jean-Philippe Labbé

All tests pass on the base classes files and the library of polytopes.

LGTM, once the bot gives the green light, I'll change it to positive review.

comment:5 Changed 4 years ago by jipilab

  • Keywords days84 added

comment:6 Changed 4 years ago by jipilab

Any idea why it does not build on the bot?

comment:7 Changed 4 years ago by mkoeppe

As far as I can see, the build failed because of an unrelated error (upstream package lrslib-062+autotools-2017-03-03.tar.gz not present on mirrors -- this seems to have been fixed since)

comment:8 Changed 4 years ago by jipilab

  • Status changed from needs_review to positive_review

The last bot test passed on 7.6.rc0. This looks good to me.

comment:9 Changed 4 years ago by mkoeppe

Thank you!

comment:10 Changed 4 years ago by vbraun

  • Branch changed from u/mkoeppe/polyhedron_zz_should_inherit_from_polyhedron_qq__not_polyhedron_base to 67eb1d7e74c7eaa0bf640550cdf60160a7a893ef
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.