Opened 6 years ago
Closed 6 years ago
#22551 closed enhancement (fixed)
Deprecate the old .field() method from polyhedron class
Reported by:  JeanPhilippe Labbé  Owned by:  

Priority:  major  Milestone:  sage7.6 
Component:  geometry  Keywords:  days84, geometry 
Cc:  Moritz Firsching, Matthias Köppe, Vincent Delecroix, Thierry Monteil, Frédéric Chapoton  Merged in:  
Authors:  JeanPhilippe Labbé  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  6291dd1 (Commits, GitHub, GitLab)  Commit:  6291dd1806a919cb9a83c4863b0c130c044742dd 
Dependencies:  Stopgaps: 
Change History (12)
comment:1 Changed 6 years ago by
Branch:  → u/jipilab/deprecate_field 

comment:2 Changed 6 years ago by
Commit:  → 1e26fe924672a8d4e2fcfc4c94326d49d086f2cd 

Status:  new → needs_review 
comment:3 followup: 8 Changed 6 years ago by
Branch:  u/jipilab/deprecate_field 

Commit:  1e26fe924672a8d4e2fcfc4c94326d49d086f2cd 
In cdd_convert
you need to test the deprecation
comment:4 Changed 6 years ago by
Branch:  → u/jipilab/deprecate_field 

Commit:  → 1e26fe924672a8d4e2fcfc4c94326d49d086f2cd 
New commits:
1e26fe9  Deprecate old keyword and method field

comment:5 followup: 7 Changed 6 years ago by
@@ 2032,8 +2032,6 @@ class Polyhedron_base(Element): """ return self.parent().base_ring()  field = base_ring  @cached_method def center(self):
No deprecation here?
comment:6 Changed 6 years ago by
Reviewers:  → Vincent Delecroix 

Status:  needs_review → needs_info 
comment:7 Changed 6 years ago by
Replying to vdelecroix:
@@ 2032,8 +2032,6 @@ class Polyhedron_base(Element): """ return self.parent().base_ring()  field = base_ring  @cached_method def center(self):No deprecation here?
Hmm. Right. I confused the keyword with the method here. I will add a deprecation warning.
comment:8 Changed 6 years ago by
Replying to vdelecroix:
In
cdd_convert
you need to test the deprecation
Since it is in a nested function, I removed the deprecation warning.
This was intended merely to make the nomenclature about base ring consistent across the geometry component...
comment:9 Changed 6 years ago by
Commit:  1e26fe924672a8d4e2fcfc4c94326d49d086f2cd → 6291dd1806a919cb9a83c4863b0c130c044742dd 

Branch pushed to git repo; I updated commit sha1. New commits:
6291dd1  Added and removed deprecation warnings

comment:10 Changed 6 years ago by
Status:  needs_info → needs_review 

comment:11 Changed 6 years ago by
Status:  needs_review → positive_review 

I can not reproduce the timeout from the patchbot.
comment:12 Changed 6 years ago by
Branch:  u/jipilab/deprecate_field → 6291dd1806a919cb9a83c4863b0c130c044742dd 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
Deprecate old keyword and method field