Opened 5 years ago

Closed 5 years ago

#22545 closed enhancement (fixed)

py3: get rid of a few cmp in py files (step1)

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords: days85
Cc: tscrim, jdemeyer, aapitzsch, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: b211ac9 (Commits, GitHub, GitLab) Commit: b211ac9de009963b683f5368373d8d93134797a2
Dependencies: Stopgaps:

Status badges

Description

as a tiny step on the looong road to python 3

Change History (11)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/22545
  • Commit set to 0629f4153a7a3510a2b8ac879dc2aede8cb9dc1f
  • Status changed from new to needs_review

let us wait for the bots


New commits:

0629f41py3: get rid of a few cmp() in py files

comment:2 Changed 5 years ago by chapoton

  • Status changed from needs_review to needs_work

comment:3 Changed 5 years ago by git

  • Commit changed from 0629f4153a7a3510a2b8ac879dc2aede8cb9dc1f to b211ac9de009963b683f5368373d8d93134797a2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

af7a2a1py3: get rid of a few cmp() in py files
b211ac9trac 22545 another cmp removal

comment:4 Changed 5 years ago by chapoton

  • Status changed from needs_work to needs_review

another try, waiting for the bots

comment:5 Changed 5 years ago by tscrim

I would say those previous failures for inequalities were actually bad tests and probably should be deleted. At least, I don't see why anyone would fundamentally be comparing morphism as the data used by the __cmp__ is not generally well-ordered, hence, essentially random.

Also, how do you feel about implementing a generic __ne__ for every subclass of SageObject that does the return not (self == other)? (Of course, this would be a separate ticket.)

comment:6 Changed 5 years ago by chapoton

green bot, please review

I have undone the changes to morphisms, kept for another ticket

comment:7 Changed 5 years ago by chapoton

  • Cc tscrim jdemeyer aapitzsch jmantysalo added

comment:8 Changed 5 years ago by chapoton

ping ?

comment:9 Changed 5 years ago by saraedum

  • Reviewers set to Julian Rüth
  • Status changed from needs_review to positive_review

comment:10 Changed 5 years ago by saraedum

  • Keywords days85 added

comment:11 Changed 5 years ago by vbraun

  • Branch changed from u/chapoton/22545 to b211ac9de009963b683f5368373d8d93134797a2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.