Opened 6 years ago
Last modified 6 weeks ago
#22539 needs_work enhancement
normalized p_minimal_polynomials
Reported by:  rrissner  Owned by:  

Priority:  major  Milestone:  
Component:  linear algebra  Keywords:  
Cc:  cheuberg  Merged in:  
Authors:  Roswitha Rissner  Reviewers:  Aly Deines 
Report Upstream:  N/A  Work issues:  
Branch:  u/aly.deines/normalized_p_minimal_polynomials (Commits, GitHub, GitLab)  Commit:  15cba83012ecaa38d5bb9127c9e0b3b3c16f4e3a 
Dependencies:  Stopgaps: 
Description (last modified by )
In general (p^t)
minimal polynomials of a matrix B
are not uniquely determined but two different (p^t)
minimal polynomials are congruent modulo p (N_{p^{t1})}(B)
where N_{(p^{t1})}(B)
is (p^{t1})
ideal of B
.
The new method normalize_nu computes the representative whose coefficients are minimal among \{0, \ldots, p^t1\}
.
Note: The new method p_t_part(f, p, t) replaces p_part(f, p) with t = 1.
Change History (9)
comment:1 Changed 6 years ago by
Cc:  cheuberg added 

Component:  PLEASE CHANGE → linear algebra 
Description:  modified (diff) 
Type:  PLEASE CHANGE → enhancement 
comment:2 Changed 6 years ago by
Branch:  → u/rrissner/normalized_p_minimal_polynomials 

comment:3 Changed 6 years ago by
Commit:  → b096cc2c70572cde1407c887ae4818119e972156 

Status:  new → needs_review 
comment:4 Changed 6 years ago by
Status:  needs_review → needs_work 

Work issues:  → author is missing 
rrissner, I could not find your handle on the wiki home page.
comment:5 Changed 6 years ago by
Authors:  → Roswitha Rissner 

comment:6 Changed 6 years ago by
Status:  needs_work → needs_review 

comment:7 Changed 5 years ago by
Branch:  u/rrissner/normalized_p_minimal_polynomials → u/aly.deines/normalized_p_minimal_polynomials 

comment:8 Changed 5 years ago by
Commit:  b096cc2c70572cde1407c887ae4818119e972156 → 15cba83012ecaa38d5bb9127c9e0b3b3c16f4e3a 

Reviewers:  → Aly Deines 
Status:  needs_review → needs_work 
Work issues:  author is missing 
Hi! I've been looking at your ticket. The code looks great. I have a few comments/questions about the documentation.
 First, in the method normalize_nu, you don't have any examples or tests of this function. You only have an indirect doctest. You should have tests such that every line of code is run via one of the tests.
 In the normalize_nu documentation you should try to keep lines to 79 characters or less (72 is prefered for documentation in the python PEP 8 style guide.)
 In the documentation, I think
B
should beself
 ``nu``  a `(p^t)`minimal polynomial of `B`
 Also, what is
S
? ``p_min_polys``  a dictionary, keys are elements `s \in \mathcal{S}` with `s \le t`, the values are the associated normalized `(p^s)`minimal polynomials `\nu_s`
 Finally, in the doctest you currently have, you should indicate that it is an indirect doctest.
New commits:
fb743b4  Merging branch 'u/rrissner/normalized_p_minimal_polynomials' of git://trac.sagemath.org/sage into t/22539/normalized_p_minimal_polynomials to sage 8.1.beta3.

15cba83  Removed trailing whitespace.

comment:9 Changed 6 weeks ago by
Milestone:  sage7.6 

New commits:
normalize_nu, p_part replaced by p_t_part