Opened 6 years ago

Closed 6 years ago

#22537 closed enhancement (fixed)

Use Python 3 metaclass syntax in Cython code

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: Frédéric Chapoton Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: ba82671 (Commits, GitHub, GitLab) Commit: ba82671db9807e151a7ae5f72fe76c4456ab4c05
Dependencies: Stopgaps:

Status badges

Description


Change History (9)

comment:1 Changed 6 years ago by Jeroen Demeyer

Summary: Use Python 3 metaclass syntax in Cython filesUse Python 3 metaclass syntax in Cython code

comment:2 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/use_python_3_metaclass_syntax_in_cython_files

comment:3 Changed 6 years ago by Jeroen Demeyer

Commit: ba82671db9807e151a7ae5f72fe76c4456ab4c05
Status: newneeds_review

New commits:

ba82671Use Python 3 metaclass syntax

comment:4 Changed 6 years ago by Frédéric Chapoton

This seems to break things quite badly.. at least the patchbot shows a rather strange result..

comment:5 in reply to:  4 Changed 6 years ago by Jeroen Demeyer

Replying to chapoton:

This seems to break things quite badly.. at least the patchbot shows a rather strange result..

I don't know what you are seeing. I see just one timeout in src/sage/doctest/test.py

comment:6 Changed 6 years ago by Frédéric Chapoton

well, my patchbot shortlog contains (among many other bad-looking things)

Attaching gdb to process id 45443.

Saved trace to /home/u1/chapoton/.sage/crash_logs/crash_TkiqJY.log
------------------------------------------------------------------------
Unhandled SIGABRT: An abort() occurred.
This probably occurred because a *compiled* module has a bug
in it and is not properly wrapped with sig_on(), sig_off().
Python will now terminate.

comment:7 in reply to:  6 Changed 6 years ago by Jeroen Demeyer

Replying to chapoton:

well, my patchbot shortlog contains (among many other bad-looking things)

It seems that your patchbot is the only one, so then this ticket probably is not the cause.

comment:8 Changed 6 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok, last run of the patchbot is green and changes look good to me

setting to positive

comment:9 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/use_python_3_metaclass_syntax_in_cython_filesba82671db9807e151a7ae5f72fe76c4456ab4c05
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.