Opened 2 years ago

Closed 2 years ago

#22535 closed defect (fixed)

Fix bug in checking validity of coordinate values on a chart

Reported by: egourgoulhon Owned by:
Priority: major Milestone: sage-7.6
Component: geometry Keywords: chart, manifolds
Cc: tscrim Merged in:
Authors: Eric Gourgoulhon Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f696a38 (Commits) Commit: f696a38cece5be4c209f4f72c24bf7893dd3317c
Dependencies: Stopgaps:

Description

The following is a bug: 

sage: M = Manifold(2, 'M')
sage: X.<x,y> = M.chart()
sage: X.add_restrictions((x^2+y^2<1, [x>0, abs(y)<1]))
sage: X.valid_coordinates(2,0)
...
AttributeError: 'list' object has no attribute 'subs'

It occurs because of some lack of depth in the analysis of the coordinate restrictions (here x^2+y^2<1 or (x>0 and abs(y)<1)). The current ticket fixes it by introducing a recursive function to check the coordinate restrictions.

Change History (4)

comment:1 Changed 2 years ago by egourgoulhon

  • Branch set to public/manifolds/bug-coord-restrict-22535
  • Cc tscrim added
  • Commit set to f696a38cece5be4c209f4f72c24bf7893dd3317c
  • Status changed from new to needs_review

New commits:

​f696a38Fix bug in checking validity of coordinate values on a chart (#22535)

comment:2 follow-up: Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 in reply to: ↑ 2 Changed 2 years ago by egourgoulhon

Thanks!

comment:4 Changed 2 years ago by vbraun

  • Branch changed from public/manifolds/bug-coord-restrict-22535 to f696a38cece5be4c209f4f72c24bf7893dd3317c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.