Opened 4 years ago

Closed 4 years ago

#22534 closed defect (fixed)

Add "long time" to doctests in the geometry component

Reported by: jipilab Owned by:
Priority: major Milestone: sage-7.6
Component: geometry Keywords: days84, doctests
Cc: chapoton, vdelecroix Merged in:
Authors: Jean-Philippe Labbé Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f41f3a4 (Commits) Commit: f41f3a4f885602448b2114fc4b9eb81a2af5ab1a
Dependencies: Stopgaps:

Description

Making tests in the files in the geometry currently takes a long time.

We should add the markup long time next to the tests that take too long.

Change History (9)

comment:1 Changed 4 years ago by jipilab

  • Branch set to u/jipilab/22534

comment:2 Changed 4 years ago by jipilab

  • Commit set to 9fd724d7a5adc6febb5900b986f766e3d9e1582d
  • Status changed from new to needs_review

New commits:

9fd724dAdded some long time markup

comment:3 follow-up: Changed 4 years ago by tscrim

This change is bad and causing the doctest failure:

  • src/sage/geometry/polyhedron/plot.py

    diff --git a/src/sage/geometry/polyhedron/plot.py b/src/sage/geometry/polyhedron/plot.py
    index a50eb16..4540377 100644
    a b def render_3d(projection, *args, **kwds): 
    8888        Graphics3d Object
    8989        sage: Polyhedron(vertices=[[1,1,1]], lines=[[0,1,0],[0,0,1]]).plot()                  # R^2 in R^3
    9090        Graphics3d Object
    91         sage: Polyhedron(rays=[[0,1,0],[0,0,1]], lines=[[1,0,0]]).plot()                      # quadrant wedge in R^2
     91        sage: Polyhedron(rays=[[0,1,0],[0,0,1]], lines=[[1,0,0]]).plot()
     92        # long time quadrant wedge in R^2
    9293        Graphics3d Object
    9394        sage: Polyhedron(rays=[[0,1,0]], lines=[[1,0,0]]).plot()                              # upper half plane in R^3
    9495        Graphics3d Object

You need the # long time on the same line, otherwise it is treated as output (see the patchbot).

comment:4 Changed 4 years ago by jdemeyer

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to needs_work

comment:5 in reply to: ↑ 3 Changed 4 years ago by jipilab

You need the # long time on the same line, otherwise it is treated as output (see the patchbot).

Oh! Got it! Thanks for the pointer!

JP

comment:6 Changed 4 years ago by git

  • Commit changed from 9fd724d7a5adc6febb5900b986f766e3d9e1582d to f41f3a4f885602448b2114fc4b9eb81a2af5ab1a

Branch pushed to git repo; I updated commit sha1. New commits:

f41f3a4Corrected one long time comment

comment:7 Changed 4 years ago by jipilab

  • Status changed from needs_work to needs_review

comment:8 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

LGTM now. Thanks.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/jipilab/22534 to f41f3a4f885602448b2114fc4b9eb81a2af5ab1a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.