Opened 5 years ago
Closed 5 years ago
#22521 closed enhancement (fixed)
py3 some care for range
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.6 |
Component: | python3 | Keywords: | |
Cc: | tscrim, jdemeyer, aapitzsch | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Jori Mäntysalo |
Report Upstream: | N/A | Work issues: | |
Branch: | f1d98ca (Commits, GitHub, GitLab) | Commit: | f1d98ca65bf8d28760439a502de5c39f60df6d31 |
Dependencies: | Stopgaps: |
Description
part of #16081, preparation for python3 iterator range
Change History (6)
comment:1 Changed 5 years ago by
- Branch set to u/chapoton/22521
- Commit set to 13911d8b7476dfa375c5afdad040f264b8db8bc7
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
- Commit changed from 13911d8b7476dfa375c5afdad040f264b8db8bc7 to f1d98ca65bf8d28760439a502de5c39f60df6d31
Branch pushed to git repo; I updated commit sha1. New commits:
f1d98ca | trac 22521 detail of doc
|
comment:3 Changed 5 years ago by
- Cc tscrim jdemeyer aapitzsch added
ok, green bot, please review (first step in the final cleanup of range)
comment:4 Changed 5 years ago by
- Reviewers set to Jori Mäntysalo
comment:5 Changed 5 years ago by
- Status changed from needs_review to positive_review
I don't understand list(range(2,12,2))[n]
.
You have changed one if len(s) == 0:
to if not s:
, but if show_points and len(points) > 0:
is not changed to if show_points and points:
.
Anyways, I mark this as positive review.
comment:6 Changed 5 years ago by
- Branch changed from u/chapoton/22521 to f1d98ca65bf8d28760439a502de5c39f60df6d31
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
waiting for the bots
New commits:
py3 some care for range