Opened 3 years ago

Closed 3 years ago

#22517 closed enhancement (fixed)

use Py_NE, PY_EQ, etc in richcmp in cython files

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: 752a1ae (Commits) Commit: 752a1ae1095792157378c4a990348afde9fcddc9
Dependencies: Stopgaps:

Description

for clarity of rich comparison code, instead of using numbers (2 for ==, etc) use the shorthands Py_NE etc

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/22517
  • Commit set to 5bcd77eee9e967719827a4b5cd765333f06b9da1
  • Status changed from new to needs_review

wait for the bots


New commits:

5bcd77efor clarity of code, use Py_EQ, Py_NE, etc, in rich comparison

comment:2 Changed 3 years ago by git

  • Commit changed from 5bcd77eee9e967719827a4b5cd765333f06b9da1 to 64c9d2aa54f016af0286e64a03ce48931aa7b314

Branch pushed to git repo; I updated commit sha1. New commits:

64c9d2atrac 22517 minimize imports

comment:3 Changed 3 years ago by aapitzsch

Please remove the comments # != etc. They aren't helpful.

comment:4 Changed 3 years ago by git

  • Commit changed from 64c9d2aa54f016af0286e64a03ce48931aa7b314 to 752a1ae1095792157378c4a990348afde9fcddc9

Branch pushed to git repo; I updated commit sha1. New commits:

752a1aetrac 22517 remove now superflous comments

comment:5 follow-up: Changed 3 years ago by chapoton

done, let us wait for the bots again

comment:6 in reply to: ↑ 5 Changed 3 years ago by aapitzsch

  • Reviewers set to André Apitzsch

Replying to chapoton:

done, let us wait for the bots again

Thanks.

Ticket can be set to positive review if bot is green.

comment:7 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

Thanks for the review, André.

green bot, setting to positive

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/22517 to 752a1ae1095792157378c4a990348afde9fcddc9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.