Opened 4 years ago

Closed 4 years ago

#22513 closed defect (fixed)

Upgrade polymake to version 3.1

Reported by: moritz Owned by:
Priority: major Milestone: sage-8.0
Component: packages: experimental Keywords: days84, polymake
Cc: vdelecroix, mkoeppe Merged in:
Authors: Moritz Firsching, Matthias Koeppe Reviewers: Matthias Koeppe, Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 9f0c6d5 (Commits, GitHub, GitLab) Commit: 9f0c6d50420346c3c5564a0d6354774520bedac6
Dependencies: #22606 Stopgaps:

Status badges

Description (last modified by mkoeppe)

With my configuration, the configure script of polymake 3.0 is not working, probably due to a new version of perl:

$ ./configure 
checking C++ compiler ... ok (g++ is GCC 6.3.0)
checking C++ library ... ok (GNU stdlibc++ 20170218, C++ 201402)
determining architecture ... Undefined subroutine &Polymake::Configure::platform_name called at support/configure.pl line 538.

Let's package the latest version of polymake, 3.1.

To build it for Sage do:

Change History (25)

comment:1 Changed 4 years ago by moritz

  • Branch set to u/moritz/polymake-beta

comment:2 Changed 4 years ago by moritz

  • Branch u/moritz/polymake-beta deleted

The tar ball, which should be put in the folder upstream can be found here: http://page.mi.fu-berlin.de/moritz/pkgs/polymake-3.1-beta2.tar.bz2

comment:3 Changed 4 years ago by mkoeppe

Before you deleted the branch, I pulled it and built successfully on Mac OS.

comment:4 Changed 4 years ago by moritz

  • Branch set to u/moritz/polymake-beta

comment:5 Changed 4 years ago by moritz

  • Commit set to d86b8ffb91080c895f82415fb47b442767242672
  • Description modified (diff)

New commits:

d86b8ffinstall of beta 3.1-beta2 now works

comment:6 Changed 4 years ago by moritz

  • Description modified (diff)
  • Status changed from new to needs_review

comment:7 Changed 4 years ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by vdelecroix

This package *completely* breaks pypolymake. Don't you want to make a different package?

comment:9 Changed 4 years ago by vdelecroix

Moreover, it is not nice to package yourself upstream. I pushed Moritz to make this package for testing purposes. I am very much against its inclusion in Sage.

Last edited 4 years ago by vdelecroix (previous) (diff)

comment:10 Changed 4 years ago by mkoeppe

  • Status changed from positive_review to needs_work

OK, I agree

comment:11 follow-up: Changed 4 years ago by mkoeppe

Also, the Singular build seems to fail with this beta version of polymake installed.

comment:12 in reply to: ↑ 11 Changed 4 years ago by vdelecroix

Replying to mkoeppe:

Also, the Singular build seems to fail with this beta version of polymake installed.

For the record, this can be fixed with

  • build/pkgs/singular/spkg-install

    diff --git a/build/pkgs/singular/spkg-install b/build/pkgs/singular/spkg-install
    index 373bd0852b..b172b0ec1f 100755
    a b config() 
    9393                --with-ntl="$SAGE_LOCAL" \
    9494                --with-flint="$SAGE_LOCAL" \
    9595                --enable-gfanlib \
     96                --disable-polymake \
    9697                --enable-Singular \
    9798                --enable-factory \
    9899                --disable-doc \

comment:13 Changed 4 years ago by mkoeppe

(this fix to Singular is #22606.)

comment:14 Changed 4 years ago by mkoeppe

  • Dependencies set to #22606

comment:15 Changed 4 years ago by mkoeppe

This new version also breaks #22683. Apparently polymake has changed its mind about some important properties:

    TypeError: initial check failed: dimension mismatch between LINEALITY_SPACE and CONE_AMBIENT_DIM

comment:16 Changed 4 years ago by mkoeppe

Polymake 3.1 was just released. We should repurpose this ticket for the upgrade.

Vincent -- objections to upgrading (if it builds OK) even if pypolymake is not ready yet for that version?

comment:17 Changed 4 years ago by mkoeppe

  • Description modified (diff)
  • Summary changed from package polymake beta to Upgrade polymake to version 3.1

comment:18 Changed 4 years ago by mkoeppe

  • Description modified (diff)
  • Milestone changed from sage-7.6 to sage-8.0

comment:19 follow-up: Changed 4 years ago by mkoeppe

comment:20 Changed 4 years ago by mkoeppe

  • Branch changed from u/moritz/polymake-beta to u/mkoeppe/polymake-beta

comment:21 in reply to: ↑ 19 Changed 4 years ago by mkoeppe

  • Commit changed from d86b8ffb91080c895f82415fb47b442767242672 to 9f0c6d50420346c3c5564a0d6354774520bedac6

Replying to mkoeppe:

A possible upstream issue: Polymake 3.1: Empty polytope has dimension 1

It was easy to work around this in #22658.


New commits:

12e7d1cinstall of beta 3.1-beta2 now works
9f0c6d5Upgrade polymake to version 3.1

comment:22 Changed 4 years ago by mkoeppe

  • Authors changed from Moritz Firsching to Moritz Firsching, Matthias Koeppe
  • Status changed from needs_work to needs_review

comment:23 Changed 4 years ago by vdelecroix

  • Reviewers changed from Matthias Koeppe to Matthias Koeppe, Vincent Delecroix

Simon worked well: all tests of the interface (#22452) pass with this new version of polymake!

comment:24 Changed 4 years ago by vdelecroix

  • Status changed from needs_review to positive_review

(hopefully the beta branch of pypolymake should be close to be working with polymake 3.1)

comment:25 Changed 4 years ago by vbraun

  • Branch changed from u/mkoeppe/polymake-beta to 9f0c6d50420346c3c5564a0d6354774520bedac6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.