Opened 5 years ago

Closed 5 years ago

#22511 closed defect (fixed)

fix a bug in the forward rule for domino insertion

Reported by: mantepse Owned by:
Priority: major Milestone: sage-7.6
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Martin Rubey Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: d9f6554 (Commits, GitHub, GitLab) Commit: d9f655481fc9c50264f71c830569782a620ff681
Dependencies: Stopgaps:

Status badges

Description (last modified by mantepse)

I made a mistake in the implementation of the forward rule in the domino growth diagrams for signed permutations. This ticket provides a fix and an appropriate test.

Change History (5)

comment:1 Changed 5 years ago by mantepse

  • Branch set to u/mantepse/fix_a_bug_in_the_forward_rule_for_domino_insertion

comment:2 Changed 5 years ago by mantepse

  • Authors set to Martin Rubey
  • Commit set to d9f655481fc9c50264f71c830569782a620ff681
  • Component changed from PLEASE CHANGE to combinatorics
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

New commits:

​d9f6554fix bugs, allow SignedPermutations as input

comment:3 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be

comment:4 Changed 5 years ago by mantepse

Thank you!

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/mantepse/fix_a_bug_in_the_forward_rule_for_domino_insertion to d9f655481fc9c50264f71c830569782a620ff681
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.