Changes between Initial Version and Version 1 of Ticket #22509, comment 78


Ignore:
Timestamp:
09/04/17 15:22:21 (3 years ago)
Author:
embray
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22509, comment 78

    initial v1  
    22> One concern with this patch is that it's really a patch bomb, which might be hard to get reviewed and merged.
    33
    4 True, but there's not much other way to handle it. John did test this extensively in OSX and got it working.  The only remaining concern was that some `spkg-check` tests weren't working.  I believe I've addressed that now, though it's hard to be 100% sure since some of those tests aren't working for me with or without this patch.
     4True, but there's not much other way to handle it (I don't mind separating some changes out to separate tickets but some of them go hand-in-hand with this). John did test this extensively in OSX and got it working.  The only remaining concern was that some `spkg-check` tests weren't working.  I believe I've addressed that now, though it's hard to be 100% sure since some of those tests aren't working for me with or without this patch.
    55
    66> I don't think you have answered [comment:65]