Opened 3 weeks ago

Closed 3 weeks ago

#22503 closed defect (fixed)

Fix treatment of symbolic derivatives in simplification of coordinate functions

Reported by: egourgoulhon Owned by:
Priority: major Milestone: sage-7.6
Component: geometry Keywords: manifolds, coordinate functions
Cc: Merged in:
Authors: Eric Gourgoulhon Reviewers: Michał Bejger
Report Upstream: N/A Work issues:
Branch: 2207350 (Commits) Commit: 220735012b437440115779f9a06b5f6b2bcf32fb
Dependencies: Stopgaps:

Description

This ticket fixes a bug that appeared in src/sage/manifolds/utilities/simplify_sqrt_real after the introduction of diff(...) instead of D[...] to denote derivatives of symbolic functions. This bug has been reported at https://ask.sagemath.org/question/36777/covariant-derivative-gives-error-why-sage-751/ and the diff(...) issue is discussed at https://groups.google.com/d/msg/sage-support/lZ4AjbmvvQE/4ZZddjLTBAAJ.

Change History (6)

comment:1 Changed 3 weeks ago by egourgoulhon

  • Branch set to public/manifolds/bug-22503
  • Commit set to 220735012b437440115779f9a06b5f6b2bcf32fb

New commits:

2207350Fix bug with diff(...) in simplify_sqrt_real

comment:2 Changed 3 weeks ago by egourgoulhon

  • Status changed from new to needs_review

comment:3 follow-up: Changed 3 weeks ago by mbejger

  • Status changed from needs_review to positive_review

Proposed fix handles the problem.

comment:4 Changed 3 weeks ago by mbejger

  • Reviewers set to Michał Bejger

comment:5 in reply to: ↑ 3 Changed 3 weeks ago by egourgoulhon

Thank you Michal for the review!

comment:6 Changed 3 weeks ago by vbraun

  • Branch changed from public/manifolds/bug-22503 to 220735012b437440115779f9a06b5f6b2bcf32fb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.