Opened 6 years ago

Closed 6 years ago

#22491 closed enhancement (fixed)

make lrslib and lidia a build-time dependencies of latte_int

Reported by: Thierry Monteil Owned by:
Priority: major Milestone: sage-7.6
Component: packages: optional Keywords: days84
Cc: Matthias Köppe Merged in:
Authors: Thierry Monteil Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: c95a9aa (Commits, GitHub, GitLab) Commit: c95a9aa286007250f1e76bd924110207776ec481
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

The lrslib and lidia optional package improve latte_int capabilities, but they need to be installed when latte_int get compiled. Through it is not strictly necessary to compile latte_int, i propose to add it as a (build-time) dependency.

lrslib can be used by using count --compute-vertex-cones=lrs (this is also exposed as a keyword argument of ehrhart_polynomial).

lidia matters for count --irrational-primal --maxdet=1000 (these are also exposed as keyword arguments).

Change History (10)

comment:1 Changed 6 years ago by Thierry Monteil

Branch: u/tmonteil/make_lidia_a_build_time_dependency_of_latte_int

comment:2 Changed 6 years ago by Thierry Monteil

Cc: Matthias Köppe added
Commit: 416888dc0c6e9edb55cc59926003a0737d063a74
Keywords: days84 added
Status: newneeds_review

New commits:

416888d#22491 add lidia as dependency of latte_int.

comment:3 Changed 6 years ago by Matthias Köppe

see #21700

comment:4 Changed 6 years ago by git

Commit: 416888dc0c6e9edb55cc59926003a0737d063a74c95a9aa286007250f1e76bd924110207776ec481

Branch pushed to git repo; I updated commit sha1. New commits:

c95a9aa#22491 add lrslib as dependency of latte_int.

comment:5 Changed 6 years ago by Thierry Monteil

Description: modified (diff)
Summary: make lidia a build-time dependency of latte_intmake lrslib and lidia a build-time dependencies of latte_int

comment:6 Changed 6 years ago by Thierry Monteil

Description: modified (diff)

comment:7 Changed 6 years ago by Vincent Delecroix

Could you provide more details in the ticket description of the additional capabilities offered?

comment:8 Changed 6 years ago by Matthias Köppe

Description: modified (diff)

comment:9 Changed 6 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

Looks reasonable to me

comment:10 Changed 6 years ago by Volker Braun

Branch: u/tmonteil/make_lidia_a_build_time_dependency_of_latte_intc95a9aa286007250f1e76bd924110207776ec481
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.