Opened 3 years ago

Closed 3 years ago

#22485 closed enhancement (fixed)

py3 get rid of the last .iteritems

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.6
Component: python3 Keywords:
Cc: tscrim, jdemeyer, aapitzsch Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: d04a0d3 (Commits) Commit: d04a0d36aeaa8e04349dd02326f654ae8a3d6ea8
Dependencies: Stopgaps:

Description (last modified by chapoton)

as a move to py3

possibly the last step to fix #15981 ?

just touch one file, which is cleaned-up a little bit

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/22485
  • Commit set to 61c6b039ec4daf87dff109d30058325e4370936b
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

61c6b03py3 get rid of the last .iteritems and one cmp in multi-filtered vectors

comment:2 Changed 3 years ago by chapoton

  • Status changed from needs_review to needs_work

some failing doctests that need investigation

comment:3 Changed 3 years ago by git

  • Commit changed from 61c6b039ec4daf87dff109d30058325e4370936b to d04a0d36aeaa8e04349dd02326f654ae8a3d6ea8

Branch pushed to git repo; I updated commit sha1. New commits:

d04a0d3trac 22485 do not touch __cmp__ for the moment ! :(

comment:4 Changed 3 years ago by chapoton

  • Status changed from needs_work to needs_review

ok, let us keep the cmp problem for another ticket..

comment:5 Changed 3 years ago by chapoton

  • Cc tscrim jdemeyer aapitzsch added

green bot, please review (easy)

comment:6 Changed 3 years ago by chapoton

very easy ticket, guys

comment:7 Changed 3 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/22485 to d04a0d36aeaa8e04349dd02326f654ae8a3d6ea8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.